-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix: docker group detection (for Nix) #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you, merging this! 🙌 |
|
Thanks, did you manage to create a vm with that installation? I'm getting docker permission issues on installation for some reason. |
|
I was able to go through the setup and am actively using the VM as I type this, yes. I'll do some further testing later today or tomorrow. |
Only thing I can think of the top of my head right now is: if it's permission issues, make sure you can run docker commands without sudo (add your user to the docker group on your configuration.nix if you haven't) @toubul |
umm interesting. I would add that it says in the UI that the container was created but WinBoat Guest API - Offline |
|
That looks to me like a docker response rather than a winboat thing. I don't really have any idea why this could be happening though. Maybe manually creating a dockur/windows docker vm would show more verbose logging? |
|
Only thing I can thing of is if your user doesn't have the |
Oh, first time I hear about the Response for Update: working, was an issue due to init with rootless docker. |
Should fix #166. I just applied the fix that @xrexy provided in the issue mentioned.
(first time i'm opening a pr on a public project so let me know if i'm doing it right c:)