Embed OpenStreetMap iframe and balance alarm layout #38
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| setTimeout(() => { | ||
| map.invalidateSize(); | ||
| }, 150); | ||
| showMapContent(embedUrl, location); |
There was a problem hiding this comment.
Avoid reloading map iframe on every poll
The new updateMap implementation always calls showMapContent and reassigns mapElement.src on every invocation. Because poll() runs every 15 s regardless of whether the coordinates change, an active alarm now forces the <iframe> to reload repeatedly, flashing the placeholder and re-fetching tiles each cycle. The previous Leaflet implementation simply updated the marker and map center without rebuilding the view. Consider caching the last embed URL or coordinates and skipping the reload when the location is unchanged to avoid noticeable flicker and unnecessary network traffic.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_690c37002cec8320a21fb1a97752b196