Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Persist history by default via instance path #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TimUx merged 2 commits into from
Nov 6, 2025
Merged

Persist history by default via instance path #50

TimUx merged 2 commits into from
Nov 6, 2025

Conversation

@TimUx
Copy link
Owner

@TimUx TimUx commented Nov 6, 2025

Summary

  • default the alarm history persistence file to the Flask instance directory when no path is configured
  • ensure the application shares the resolved persistence path with the config and alarm store
  • add regression tests covering the default path selection and persistence across app instances

Testing

  • pytest

https://chatgpt.com/codex/tasks/task_e_690cfa30605083209787acfeb4954d0f

@TimUx TimUx merged commit b40570b into main Nov 6, 2025
@TimUx TimUx deleted the codex/rename-column-and-filter-entries branch November 6, 2025 20:04
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Nov 6, 2025

💡 Codex Review

https://github.com/TimUx/alarm-dashboard/blob/ac09ce6e6832b7985455d4d9d96cf918814de063/alarm_dashboard/templates/history.html#L59-L68
P1 Badge Preserve legacy groups when AAO vehicles are missing

The history template now renders only entry.aao_groups for the “Alarmierte Fahrzeuge” column. Alarms parsed from plain‑text emails or older persisted history populate groups but leave aao_groups unset, so after this change those rows always display “-” even though the group information is available. The live dashboard already falls back to alarm.groups, so the history view should do the same to avoid dropping data for non-AAO alarm formats.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimUx