Issue 16 fix url bug #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google translate gives error even with strings that are similar to protocols (e.g. htt://, abc://)
Tomeriko96
requested changes
May 7, 2025
Owner
Tomeriko96
left a comment
There was a problem hiding this comment.
- Please fix the errors in the automated checks
- the
helperfunctionsdirectory should not be used for this url_helpers.R --> should go to the R/ directory instead
Owner
|
Hi @aslamht Thank you for your PR. Please fix the issues and look into the code review comments for me to merge. Also provide example cases with and without url links in the text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds error handling for (malformed) URLs in the google_translate function.
Fixes
Fixes #16
Notes
This PR applies the fix for malformed URL placeholders to the main
google_translate()function.Other variants of
google_translatestill need this update, but I currently don't have time to apply it across all of them. I recommend tracking this as a follow-up task.