Resolve CRAN issues then resubmit #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachmaninoffpk
approved these changes
Oct 8, 2025
Collaborator
rachmaninoffpk
left a comment
There was a problem hiding this comment.
Everything looks good. Make sure to update version from 1.1.2.9000 to 1.1.3 for CRAN submission, or that might get caught by the auto checks.
Collaborator
Author
Yep, I do:
Will make a separate PR for dev-->main update if this gets accepted on CRAN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Jason's ORCID comment in description file and dropped the citations column with bad Pubmed link