Thanks to visit codestin.com
Credit goes to github.com

Skip to content

First timestep of disaggregation may end up constant. #223

@arbennett

Description

@arbennett

From Slack I wrote:

Okay, I now remember what was going on. Basically, we compute the time of sunrise and sunset for each day, and use a simple linear fit on vapor pressure to disaggregate. Now the problem occurs on the first timestep specifically because this has time periods before the first sunrise (generally). Then, when we do this linear fit, we just extrapolate back in time. Occasionally this can put you in a position of negative relative humidity, which would cause NaNs to get produced by longwave and humidity. So, to alleviate this we just backfilled as constant instead of linearly interpolating backwards.

However, the backfilling I implemented happens after all of the other caluclations. Instead we should backfill vapor pressure before calculating longwave, humidity, etc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions