This is a follow up item to the work being done to move to a shared project approach (#2900).

The VSSDK analyzers were added as a part of modernization and shared project move efforts. The analyzers are producing ~30 warnings that need to be cleaned up. The work to clean them up does require a bit of modernization to some of the code, mostly using JoinableTaskFactory. That is pretty separable from the shared project change and hence want to do that as a follow up item.