Allow Comments to be created with a passed `author_ip` #1880

rachelbaker · 2015-12-21T02:14:10Z

This PR allows the comment_author_IP value to be set when creating a comment. While working on this, I remembered why we don't handle this field... while with wp_insert_comment() you can as of WP 4.3 set the comment_author_IP BUT you cannot modify this field in wp_update_comment().

Questions:

Do we allow this property to be set when creating a Comment, BUT not allow it to be edited? How should that be reflected in the schema?
Should we add a filter for the default comment_author_IP value (currently 127.0.0.1)?

UPDATE:

This PR has been refreshed and as of WP 4.5 the comment_author_ip property can be modified. View details on the refresh: #1880 (comment)

Fixes #1788

…se` method and return error if invalid

rachelbaker · 2015-12-21T02:32:11Z

@WP-API/amigos thoughts?

danielbachhuber · 2015-12-21T16:39:08Z

lib/endpoints/class-wp-rest-comments-controller.php

What if we added ip_address as a new format in our schema, so validation could happen much earlier (and in batch)?

rachelbaker · 2015-12-31T19:56:14Z

Related core ticket: https://core.trac.wordpress.org/ticket/35276

danielbachhuber · 2015-12-31T23:45:23Z

Something I've been thinking about recently with regards to whether or not fields should be editable: import / export. If someone were to build a import / export workflow based on the REST API, which seems totally reasonable to me, it seems like a reasonable assumption they should be able to update most any fields for resources.

rachelbaker · 2016-01-05T16:18:20Z

Something I've been thinking about recently with regards to whether or not fields should be editable: import / export. If someone were to build a import / export workflow based on the REST API, which seems totally reasonable to me, it seems like a reasonable assumption they should be able to update most any fields for resources.

@danielbachhuber, can you please add those thoughts to https://core.trac.wordpress.org/ticket/35276? Additional supporting opinions will help.

rachelbaker · 2016-03-13T17:19:15Z

In WP 4.5 this will no longer be blocked on core. I will pick this back up after release.

caglaroner · 2016-04-20T23:59:35Z

@rachelbaker & @danielbachhuber Great job on the WP-API and thank you very much for all your contributions.

Our team is currently blocked on this issue (more specifically the post comment part) and we would hate to branch out and patch it on our end.

Is there any timeline or progress on this issue?

codecov-io · 2016-05-07T15:03:08Z

Current coverage is 93.83%

Merging #1880 into develop will decrease coverage by -0.73%

@@            develop   #1880   diff @@
=======================================
  Files            11      13     +2   
  Lines          3627    3766   +139   
  Methods         171     183    +12   
  Branches          0       0          
=======================================
+ Hits           3430    3534   +104   
- Misses          197     232    +35   
  Partials          0       0

9 files (not in diff) in lib/endpoints were modified. more
- Misses +7
- Hits -96
2 files (not in diff) in lib/endpoints were created. more
File ...ments-controller.php was modified. more
- Misses +9
- Partials 0
- Hits 0
File plugin.php (not in diff) was modified. more
- Misses +3
- Partials 0
- Hits -48

Powered by Codecov. Last updated by 40360af...278c407

New function `rest_is_ip_address()` checks if a value is a valid v4 IP address. It uses regex because core cannot guarantee support for `filter_var`.

codecov-io · 2016-05-08T15:40:54Z

Current coverage is 94.54%

Merging #1880 into develop will decrease coverage by -<.01%

@@            develop      #1880   diff @@
==========================================
  Files            11         11          
  Lines          3627       3642    +15   
  Methods         171        171          
  Messages        171          0   -171   
  Branches          0          0          
==========================================
+ Hits           3430       3443    +13   
- Misses          197        199     +2   
  Partials          0          0

File ...ments-controller.php was modified. more
- Misses +1
- Partials 0
- Hits -1

Powered by Codecov. Last updated by 40360af...d051e65

…or on update

rachelbaker · 2016-05-08T16:46:44Z

@WP-API/amigos This PR has been refreshed and is ready for review.

Handles setting and updating the author_ip property on comment create & update
Uses 127.0.0.1 as the default author_ip value in the schema
Adds a new ipv4 string format (which matches the following example on the JSON Schema site: http://json-schema.org/example2.html)
Adds the IP validation utility function rest_is_ip_address() which ideally I would like to get into WP core.

rachelbaker added 4 commits December 20, 2015 16:33

Allow the comment_author_IP value to be set

c155cac

Move the comment_author_IP validation to the `prepare_item_for_databa…

04b3fcd

…se` method and return error if invalid

Prevent fatal error when prepare_item_for_database returns a WP_Error

fac3945

Add unit tests for creating a comment with author_ip

18bee8c

rachelbaker added Review Discussion labels Dec 21, 2015

rachelbaker added this to the 2.0 Beta 10 milestone Dec 21, 2015

rachelbaker mentioned this pull request Dec 21, 2015

Fix fatal error when prepare_item_for_database returns a WP_Error #1881

Closed

danielbachhuber reviewed Dec 21, 2015
View reviewed changes

rachelbaker added the Blocked on Core label Dec 31, 2015

Merge branch 'develop' into 1788-comment-author-IP

2976c92

danielbachhuber modified the milestones: 2.0 Beta 11, 2.0 Beta 10 Jan 11, 2016

danielbachhuber modified the milestones: 2.0 Beta 11, 2.0 Beta 12 Jan 20, 2016

Merge branch 'develop' into 1788-comment-author-IP

ba6cc80

danielbachhuber modified the milestones: 2.0 Beta 12, 2.0 Beta 13 Feb 9, 2016

rachelbaker added Needs Refresh and removed Blocked on Core Discussion labels Mar 13, 2016

rachelbaker removed the Review label Mar 13, 2016

danielbachhuber modified the milestones: 2.0 Beta 13, 2.0 Mar 14, 2016

Merge branch 'develop' into 1788-comment-author-IP

8d7c80b

rachelbaker added 4 commits May 7, 2016 13:24

Remove read-only attribute from author_ip

377c48d

Use string format type of 'ipv4' to validate comment author IP address

52542d3

New function `rest_is_ip_address()` checks if a value is a valid v4 IP address. It uses regex because core cannot guarantee support for `filter_var`.

Use the schema to set 127.0.0.1 as the default comment author IP

ebdcd25

Update tests and improve coverage

7f5c77e

rachelbaker added Review and removed Needs Refresh labels May 8, 2016

rachelbaker added 3 commits May 8, 2016 10:48

Add space to fix PHPCS error

a7b033f

Remove unneeded check on prepare_item_for_database returning a WP_Err…

d051e65

…or on update

Similar to d051e65 this removes the unneeded check on comment create

6dde6ce

rachelbaker merged commit 8edf3fc into develop Jun 17, 2016

rachelbaker deleted the 1788-comment-author-IP branch June 17, 2016 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow Comments to be created with a passed `author_ip` #1880

Allow Comments to be created with a passed `author_ip` #1880

Uh oh!

rachelbaker commented Dec 21, 2015 •

edited

Loading

Uh oh!

rachelbaker commented Dec 21, 2015

Uh oh!

danielbachhuber Dec 21, 2015

Uh oh!

rachelbaker commented Dec 31, 2015

Uh oh!

danielbachhuber commented Dec 31, 2015

Uh oh!

rachelbaker commented Jan 5, 2016

Uh oh!

rachelbaker commented Mar 13, 2016

Uh oh!

caglaroner commented Apr 20, 2016 •

edited

Loading

Uh oh!

codecov-io commented May 7, 2016

Uh oh!

codecov-io commented May 8, 2016 •

edited

Loading

Uh oh!

rachelbaker commented May 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Allow Comments to be created with a passed author_ip #1880

Allow Comments to be created with a passed author_ip #1880

Uh oh!

Conversation

rachelbaker commented Dec 21, 2015 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Questions:

UPDATE:

Uh oh!

rachelbaker commented Dec 21, 2015

Uh oh!

danielbachhuber Dec 21, 2015

Choose a reason for hiding this comment

Uh oh!

rachelbaker commented Dec 31, 2015

Uh oh!

danielbachhuber commented Dec 31, 2015

Uh oh!

rachelbaker commented Jan 5, 2016

Uh oh!

rachelbaker commented Mar 13, 2016

Uh oh!

caglaroner commented Apr 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented May 7, 2016

Current coverage is 93.83%

Uh oh!

codecov-io commented May 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 94.54%

Uh oh!

rachelbaker commented May 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Allow Comments to be created with a passed `author_ip` #1880

Allow Comments to be created with a passed `author_ip` #1880

rachelbaker commented Dec 21, 2015 •

edited

Loading

caglaroner commented Apr 20, 2016 •

edited

Loading

codecov-io commented May 8, 2016 •

edited

Loading