Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Remove extra date handling errors and expand on unit tests #1917

Merged
merged 12 commits into from
Dec 29, 2015
Merged

Remove extra date handling errors and expand on unit tests #1917

merged 12 commits into from
Dec 29, 2015

Conversation

@rachelbaker
Copy link
Member

@rachelbaker rachelbaker commented Dec 28, 2015

  • Remove unused date error handling for invalid Comment & Post dates (handled by schema validation)
  • Add unit tests for updating a comment with invalid dates
  • Add unit test for creating a comment with an invalid date
  • Add unit tests for updating Posts with invalid dates
  • Add readonly attribute to the modified dates for Posts, since WP doesn't allow them to be set in wp_insert_post() or wp_update_post()
  • Add a unit test to make sure a readonly property (like modified) is ignored per 0e8364e

Replaces #1881

@rachelbaker
Fix fatal error when prepare_item_for_database returns a WP_Error
ccfc89f
@rachelbaker
Merge branch 'develop' into fix-fatal-comment-dbprepare
af626fa
@rachelbaker
Add unit test for creating a comment with an invalid date
c470e2b
@rachelbaker
Remove unused date error handling for invalid Comment dates
06b1559 
This is handled by the schema validation already
@rachelbaker
Add unit tests for updating a comment with invalid dates
6125f51
@rachelbaker
Remove unused date error handling for invalid Post dates
8eaa821 
This is handled by the schema validation already
@rachelbaker
Add unit tests for creating and updating Posts with invalid dates
2b40014
@rachelbaker
Add readonly attribute to the modified dates for Posts
726fbe2
@rachelbaker
Remove duplicate unit test for invalid date
73c9ca2 
See `test_create_post_with_invalid_date()`
@rachelbaker
Add unit tests for modified dates of Posts
26e6228
@rachelbaker
Change modified date test to just ignore the readonly attribute
1477188
@rachelbaker
After 06b1559 we no longer can return a WP_Error
ae302aa
@rachelbaker rachelbaker mentioned this pull request Dec 28, 2015
Closed
danielbachhuber
danielbachhuber reviewed Dec 29, 2015
View reviewed changes
tests/test-rest-posts-controller.php
Copy link
Member

@danielbachhuber danielbachhuber Dec 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the next person to be curious as to whether rand_str() can produce a valid date, no it can't — it uses md5() under the hood.

@danielbachhuber
Copy link
Member

danielbachhuber commented Dec 29, 2015

Look at all of those unit tests! 😄 💕

danielbachhuber added a commit that referenced this pull request Dec 29, 2015
@danielbachhuber
Merge pull request #1917 from WP-API/invalid-date-errors
8d382aa 
Remove extra date handling errors and expand on unit tests
@danielbachhuber danielbachhuber merged commit 8d382aa into develop Dec 29, 2015
@danielbachhuber danielbachhuber deleted the invalid-date-errors branch December 29, 2015 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rachelbaker @danielbachhuber