Sync upstream #139
Merged
Sync upstream #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 4.1.7. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v2...v4.1.7) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 4.1.7. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v2...v4.1.7) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 4.1.7. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v2...v4.1.7) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…-github/workflows/actions/download-artifact-4.1.7 Bump actions/download-artifact from 2 to 4.1.7 in /.github/workflows
…in-index Fix typing of `array.new` in the index of instructions
Noticed that the existing tests didn't exercise out-of-bounds indexing of the data segment, so I added a test for that. At the same time, since I was already creating a dedicated `.wast` file for testing `array.new_data`, I also added a few general tests to round the file out. Some of these might technically duplicate things that already happen to be tested in `array.wast`, but I think that's probably fine, and that it is good to have dedicated tests in this new file. I can remove them if we'd rather not have these potential-duplicate tests.
…s-array-new-data Expand tests for `array.new_data`
Similar to WebAssembly/gc#562 but for `array.new_elem`. I opted to exercise both expression-style elements and the old MVP-style function-index elements, as they have slightly different representations in Wasmtime and that means we end up doing the indexing in two different code paths depending on which type of element segment we have. Figured that other engines might have similar code paths so it's good to test both.
…-bounds-tests Test out-of-bounds element segment indexing for `array.new_elem`
The table maximum is now a 64-bit values, so test that we actually support values outside the 32-bit range.
…mbly#1849) Also test that the instructions trap when the offset and size overflow back to zero, with and without the segments having been dropped.
…ebAssembly#573) Specifically around the requirements that both field types have the same mutability and that the storage type must be exactly the same when the field type is mutable.
Collaborator
Author
Collaborator
This is an unfortunate result of, the type-matching in AL interpreter being totally hard-coded. This fix should work.. for now, but eventually, this hard-codeness should be removed. |
Collaborator
Author
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs with the upstream wasm-3.0 branch.
That also added a couple of new tests, and unfortunately, one of them, gc/array_new_data, fails. The error is that the algorithm for the
$cunpackfunction returns an empty result. Having done a little print-debugging, I found that this happens for the argumentI32, which should be working just fine according to the function's definition. I suspect that there is a bug with the pattern matching on SubE patterns, possibly in the interpreter or the translation.Can somebody with familiarity of the interpreter please have a look?
Btw, we are now passing 100% of tests without passing all of them. :)