Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ntheanh201
Copy link

@ntheanh201 ntheanh201 commented May 28, 2025

  • Creates a new GitHub Actions workflow to automatically build and publish the nvitop-exporter Docker image to GitHub Container Registry (GHCR) on releases.

@XuehaiPan
Copy link
Owner

Hi @ntheanh201, thanks a lot for the contribution!

This PR looks good. But before merging this, I am wondering whether it is worth having a separate docker image for nvitop-exporter. It is very easy to install with pipx or uvx. For docker users, they can access nvitop-exporter via the docker image for uv (uvx).

docker run -it --rm --runtime=nvidia --gpus=all \
    ghcr.io/astral-sh/uv:python3.13-bookworm-slim \
    uvx nvitop-exporter

@XuehaiPan XuehaiPan self-assigned this Jun 2, 2025
@XuehaiPan XuehaiPan added enhancement New feature or request exporter Something related to the metrics exporter labels Jun 2, 2025
@ntheanh201
Copy link
Author

Hi @XuehaiPan, you're right about your concern. But I still think it's better when everyone gets a ready-to-run container instead of having to remember the uvx command (in the scope of my PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request exporter Something related to the metrics exporter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants