src/Waypoint: allow non-airport home waypoint #1481
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes FindHomeLocation function to allow non-airport home waypoint
a878814 to
a5486dc
Compare
8112326 to
a7770b6
Compare
Member
|
This has been merged in c46a6a6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the FindHomeLocation function to be like the FindHomeId and FindFlaggedHome functions in not requiring the home waypoint to be an airport. For reference, it’s also possible for the user to manually designate (via the “Set as New Home” button) a non-airport waypoint as the home waypoint. For many hang glider and paraglider pilots, the home waypoint is a mountaintop launch where landing isn’t possible.
Without this change, in certain scenarios, the “home” designation of a non-airport waypoint can be unexpectedly lost. For example, if a non-airport waypoint that exists in the “Waypoints” file has been set as “home” and the user changes which file is selected for “More waypoints”, the “home” designation of the user-desired waypoint is lost.