Better thermal and flarm gauge #1551
Conversation
|
Cool Thx. I will review it asap. |
|
|
There was a problem hiding this comment.
So its very cleanly done. All good.
3 Points we should look at:
- I think we should change current default overlayin the infoboxen. 90% don't change the defaults, we shoudl set it to avoid the infoboxen for example bottom left ib for thermal assistant and bottom right for the traffic gauge.
- In the current configuration dialogs the flarm configuration is under Look -> ScreenLayout, we should move it to the Gauges->Flarm, other page.
- Please add a NEWS entry so we can merge this.
957129e to
9354259
Compare
All three addressed now. |
| { TrafficSettings::GaugeLocation::TOP_LEFT_AVOID_IB, | ||
| N_("Top Left (Avoid Infoboxes)") }, | ||
| { TrafficSettings::GaugeLocation::TOP_RIGHT_AVOID_IB, | ||
| N_("Top Right (Avoid Infoboxes)") }, | ||
| { TrafficSettings::GaugeLocation::BOTTOM_LEFT_AVOID_IB, | ||
| N_("Bottom Left (Avoid Infoboxes)") }, | ||
| { TrafficSettings::GaugeLocation::BOTTOM_RIGHT_AVOID_IB, | ||
| N_("Bottom Right (Avoid Infoboxes)") }, | ||
| { TrafficSettings::GaugeLocation::CENTER_TOP_AVOID_IB, | ||
| N_("Center Top (Avoid Infoboxes)") }, | ||
| { TrafficSettings::GaugeLocation::CENTER_BOTTOM_AVOID_IB, | ||
| N_("Center Bottom (Avoid Infoboxes)") }, |
There was a problem hiding this comment.
Can you align the Text strings with the one for the Flarm gauge (case etc.) This would mean less translation strings.
There was a problem hiding this comment.
These are the strings for Flarm gauge, you mean have them match the thermal assistant ones?
I just copied these over so they should already be translated no? (not sure how it works)
Since flarm has more options is suppose changing the ones of the thermal assistent is best? Otherwise we definitely add strings to translate. You want this to be separate commit?
There was a problem hiding this comment.
Correction these are indeed new strings. What format should i go with
"Top Left" or "Top left"
There was a problem hiding this comment.
"Top left". Pretty much all the other strings are written in that fashion.
…_CASE More commonly used for similar types in code also changed British "centre" to American "center" Based on the fact that also "color" is used and not "colour". We should stick with one English language
…rm radar to avoid infoboxes
…ocation settings from Look -> ScreenLayout to the Gauges->Flarm, other page
Avoid infoboxes by default
Bottom right avoiding info boxes by default
9354259 to
99bfaa5
Compare
Based on comment in #1526