FLARM Target Colours in Radar Display #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordfolken
reviewed
Feb 7, 2025
lordfolken
requested changes
Feb 7, 2025
Member
lordfolken
left a comment
There was a problem hiding this comment.
So i like the improvment. Please have a look at my comment concerning the 50m separation.
The other thing:
Please reword your commits to the following:
File:
(on a new line) the reasoning behind.
Also the second one seems to be a fixup commit for the first, please mend it in.
You can use git rebase -i HEAD~2 to interactivily update the commits, then do a git push --force to this branch.
Contributor
Author
|
Rebase done as above |
…ency This commit is based on description and discussion on: XCSoar#1643 Within the map FLARM- targets are colour coded. Blue means "above", green means "below" and violet means "same height" The targets in the radar display (small and big) become now the same colours. The original colour "blue" in the radar display indicated the selected target (i.e. by tapping on it on the touchscreen). Also the upper left field with the FlarmID or callsign was displayed within this blue colour. Now this blue colour is no more used. The selected target is visualy marked by a bold border line. The original radar classified the targets into 2 types (passive- with engines) and active (gliders,para-gliders) The text beside the targets shows height or sink/ascend- rate. It was originaly coded in grey colour. Because the used blue and grey colour colour is no more used the text beside the FLARM- target is no more necessary to render with a shadow (it was necessary in "Dark Mode" because grey on a black background is badly visible). The border of map targets "below" and "above" is originaly programmed in /src/Renderer/TrafficRenderer.cpp this is only 50 Meters above and below. This range was now also used within the radar display. This is a bit narrow and should be changed in future.
Contributor
Author
|
Tried to explain this on top of the PR:
We are agree we have no problem in white mode. Shadowing text on white background with white makes no sense.
In dark mode the target text was shadowed with white (because blue text on black background is badly visible)
See the image in the screenshot.
The not selected targets became a grey color text which is also badly visible on dark mode.
Now we have consistent target colours in the small and big radar. The blue colour is no more used for selected target. The target colour now indicates above, below, same height (colours sky-blue, land-green, pink)
The text beside te target in white mode is allways black and in dark mode allways white. To render white text in addition with white shadow blows the text unnecessary.
Hope this is now clear.
Von: kobedegeest ***@***.***>
Gesendet: Dienstag, 8. April 2025 09:42
An: XCSoar/XCSoar ***@***.***>
Cc: fraktal-sb ***@***.***>; Author ***@***.***>
Betreff: Re: [XCSoar/XCSoar] FLARM Target Colours in Radar Display (PR #1660)
@kobedegeest commented on this pull request.
_____
In src/Gauge/FlarmTrafficWindow.cpp <#1660 (comment)> :
@@ -427,9 +426,6 @@ FlarmTrafficWindow::PaintRadarTarget(Canvas &canvas,
sc[i].y - int(sz.height / 2),
};
- // Draw vertical speed shadow
- RenderShadowedText(canvas, tmp, tp, false);
why did this get removed?
—
Reply to this email directly, view it on GitHub <#1660 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQRW2CNG46ATAGHJTWSBXA32YN4WBAVCNFSM6AAAAABWKU3OQGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONBYHE4TONZXGM> .
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File:
This commit is based on description and discussion on #1643
Within the map FLARM- targets are colour coded. Blue means "above", green means "below" and violet means "same height".
The targets in the radar display (small and big) become now the same colours.
The original colour "blue" in the radar display indicated the selected target (i.e. by tapping on it on the touchscreen). Also the upper left field with the FlarmID or call-sign was displayed within this blue colour. Now this blue colour is no more used.The selected target is visually marked by a bold border line.
The original radar classified the targets into 2 types (passive- with engines) and active (gliders,para-gliders).
The text beside the targets shows height or sink/ascend- rate. It was originally coded in grey colour. Because the used blue and grey colour colour is no more used the text beside the FLARM- target is no more necessary to render with a shadow (it was necessary in "Dark Mode" because grey on a black background is badly visible).
The border of map targets "below" and "above" is originally programmed in /src/Renderer/TrafficRenderer.cpp and is only 50 Meters above and below. This range was now also used within the radar display. This is a bit narrow and should be changed in future.