Thanks to visit codestin.com
Credit goes to github.com

Skip to content

XCVario: S2F parsing docs & XCVario Tests for Driver #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

XCVario: S2F parsing docs & XCVario Tests for Driver #1757

merged 2 commits into from
May 28, 2025

Conversation

@lordfolken
Copy link
Member

@lordfolken lordfolken commented May 8, 2025

Your PR should:

  • all description should be in the commit messages (no text in the pr)
  • your pr should be rebased on the current HEAD
  • one commit per atomic feature (every commit should build)
  • no fixup commits
  • pass all the compile and CI targets

For coding, style guide, architecture information please see our development guide:
https://xcsoar.readthedocs.io/en/latest/index.html

@lordfolken lordfolken requested a review from a team as a code owner May 8, 2025 22:05
@lordfolken lordfolken linked an issue May 8, 2025 that may be closed by this pull request
XCVario: S2F is not passed to XCSoar #1756
Open
@lordfolken lordfolken marked this pull request as draft May 16, 2025 22:26
@lordfolken
Copy link
Member Author

lordfolken commented May 19, 2025

So the commit was based on wrong information. Nevertheless i"d like the test for the driver and will correct the documentation.

@iltis42
Copy link
Contributor

iltis42 commented May 22, 2025

So the commit was based on wrong information. Nevertheless i"d like the test for the driver and will correct the documentation.

Yes, a test is okay, the fix in docu as well. The code commit not.

@lordfolken lordfolken changed the title XCVario: Corect S2F parsing XCVario: S2F parsing docs & XCVario Tests for Driver May 27, 2025
@lordfolken lordfolken marked this pull request as ready for review May 27, 2025 19:36
@lordfolken lordfolken removed a link to an issue May 27, 2025
XCVario: S2F is not passed to XCSoar #1756
Open
@lordfolken lordfolken added this to the v7.44 milestone May 27, 2025
@lordfolken lordfolken merged commit 32b2c26 into XCSoar:master May 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v7.44

Development

Successfully merging this pull request may close these issues.

2 participants

@lordfolken @iltis42