Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix composer warning about uppercase in require block #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2019
Merged

Fix composer warning about uppercase in require block #2557

merged 2 commits into from
Oct 3, 2019

Conversation

@hnnweb
Copy link
Contributor

@hnnweb hnnweb commented Oct 2, 2019 •
edited
Loading

Fix composer warning about uppercase in require block

$ composer install
Deprecation warning: require.rmccue/Requests is invalid, it should not contain uppercase characters. Please use rmccue/requests instead. Make sure you fix this as Composer 2.0 will error.
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating autoload files

@hnnweb
Update composer.json
9a9e8d3 
Fix composer warning about uppercase in require block
@ozh
Copy link
Member

ozh commented Oct 2, 2019

Sure. I'll let @LeoColomb say if there is potential impact to this, I'm not even sure what we really need this composer file for (should the composer lock file be updated as well? other composer include files?)

LeoColomb
LeoColomb requested changes Oct 3, 2019
View reviewed changes
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the composer lock file be updated as well

Indeed, the lock must be updated. 🙂

@hnnweb
Copy link
Contributor Author

hnnweb commented Oct 3, 2019

Updated the lock file. Ran composer update nothing

@hnnweb
Copy link
Contributor Author

hnnweb commented Oct 3, 2019 •
edited
Loading

It actually wrote

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   composer.lock
	modified:   includes/vendor/autoload.php
	modified:   includes/vendor/composer/ClassLoader.php
	modified:   includes/vendor/composer/LICENSE
	modified:   includes/vendor/composer/autoload_real.php
	modified:   includes/vendor/composer/installed.json

no changes added to commit (use "git add" and/or "git commit -a")

this aswell. Want them too?

LeoColomb
LeoColomb approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope that looks good.

@LeoColomb LeoColomb changed the title Update composer.json Fix composer warning about uppercase in require block Oct 3, 2019
@LeoColomb LeoColomb merged commit 207a32e into YOURLS:master Oct 3, 2019
@LeoColomb LeoColomb mentioned this pull request Nov 19, 2019
Closed
doronbehar added a commit to doronbehar/YOURLS that referenced this pull request Feb 11, 2020
@doronbehar
Merge branch 'master' of https://github.com/YOURLS/YOURLS
5e66483 
* 'master' of https://github.com/YOURLS/YOURLS:
  Bump for next release
  Bump
  bumped version number (YOURLS#2595)
  Add vector version of YOURLS logo (YOURLS#2548)
  Trim overlong client information  (YOURLS#2574)
  Rearrange opencollective badges
  Add jsonp parameter in API as a fallback to match documentation (YOURLS#2567)
  Update plugin.php (YOURLS#2562)
  Fix composer warning about uppercase in require block (YOURLS#2557)
  Split test in 2 (YOURLS#2558)
  Core-ify "Random Keywords" plugin (YOURLS#2367)
tomtenuta pushed a commit to tomtenuta/YOURLS that referenced this pull request Nov 4, 2025
@hnnweb @LeoColomb
Fix composer warning about uppercase in require block (YOURLS#2557)
fbcf65e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ozh ozh ozh approved these changes

@LeoColomb LeoColomb LeoColomb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hnnweb @ozh @LeoColomb