Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ffed7a9

Browse files
YizackYizack
committed
test: error prop must be truthy on error
1 parent 14a755a commit ffed7a9

File tree

7 files changed

+38
-38
lines changed

7 files changed

+38
-38
lines changed

‎test/domains.test.ts‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ describe("provision", () => {
113113
const domains = new Domains(mockClient);
114114
const { data, error } = await domains.provision(fake.provision);
115115

116-
expect(error).toBeDefined();
116+
expect(error).toBeTruthy();
117117
expect(data).toBeNull();
118118
expect(mockClient.post).toHaveBeenCalled();
119119
});
@@ -175,7 +175,7 @@ describe("bulkProvision", () => {
175175
{ domain: fake.provision.domain }
176176
]);
177177

178-
expect(error).toBeDefined();
178+
expect(error).toBeTruthy();
179179
expect(results).toBeNull();
180180
expect(mockClient.post).toHaveBeenCalled();
181181
});
@@ -231,7 +231,7 @@ describe("list", () => {
231231
const domains = new Domains(mockClient);
232232
const { domains: domainsList, error } = await domains.list();
233233

234-
expect(error).toBeDefined();
234+
expect(error).toBeTruthy();
235235
expect(domainsList).toEqual([]);
236236
expect(mockClient.get).toHaveBeenCalled();
237237
});
@@ -275,7 +275,7 @@ describe("delete", () => {
275275
const domains = new Domains(mockClient);
276276
const { success, error } = await domains.delete(fake.provision.domain);
277277

278-
expect(error).toBeDefined();
278+
expect(error).toBeTruthy();
279279
expect(success).toBe(false);
280280
expect(mockClient.delete).toHaveBeenCalled();
281281
});
@@ -336,7 +336,7 @@ describe("addListEntry", () => {
336336
const domains = new Domains(mockClient);
337337
const { entry, error } = await domains.addListEntry(fake.provision.domain, fake.addListEntry.options);
338338

339-
expect(error).toBeDefined();
339+
expect(error).toBeTruthy();
340340
expect(entry).toBeNull();
341341
expect(mockClient.post).toHaveBeenCalled();
342342
});
@@ -397,7 +397,7 @@ describe("listEntries", () => {
397397
const domains = new Domains(mockClient);
398398
const { entries, error } = await domains.listEntries(fake.provision.domain, fake.addListEntry.options.listName);
399399

400-
expect(error).toBeDefined();
400+
expect(error).toBeTruthy();
401401
expect(entries).toEqual([]);
402402
expect(mockClient.get).toHaveBeenCalled();
403403
});
@@ -455,7 +455,7 @@ describe("deleteListEntry", () => {
455455
const domains = new Domains(mockClient);
456456
const { success, error } = await domains.deleteListEntry(fake.provision.domain, fake.addListEntry.options);
457457

458-
expect(error).toBeDefined();
458+
expect(error).toBeTruthy();
459459
expect(success).toBe(false);
460460
expect(mockClient.delete).toHaveBeenCalled();
461461
});
@@ -498,7 +498,7 @@ describe("createLoginLink", () => {
498498
const domains = new Domains(mockClient);
499499
const { link, error } = await domains.createLoginLink(fake.provision.domain);
500500

501-
expect(error).toBeDefined();
501+
expect(error).toBeTruthy();
502502
expect(link).toBeNull();
503503
expect(mockClient.get).toHaveBeenCalled();
504504
});
@@ -557,7 +557,7 @@ describe("setDownstreamAddress", () => {
557557
const domains = new Domains(mockClient);
558558
const { success, error } = await domains.setDownstreamAddress(fake.provision.domain, fake.listDownstreamAddresses.records);
559559

560-
expect(error).toBeDefined();
560+
expect(error).toBeTruthy();
561561
expect(success).toBe(false);
562562
expect(mockClient.put).toHaveBeenCalled();
563563
});
@@ -626,7 +626,7 @@ describe("listDownstreamAddresses", () => {
626626
const domains = new Domains(mockClient);
627627
const { records, error } = await domains.listDownstreamAddresses(fake.provision.domain);
628628

629-
expect(error).toBeDefined();
629+
expect(error).toBeTruthy();
630630
expect(records).toEqual([]);
631631
expect(mockClient.get).toHaveBeenCalled();
632632
});
@@ -683,7 +683,7 @@ describe("updateApiKey", () => {
683683
const domains = new Domains(mockClient);
684684
const { success, error } = await domains.updateApiKey(fake.provision.domain, "new-api-key");
685685

686-
expect(error).toBeDefined();
686+
expect(error).toBeTruthy();
687687
expect(success).toBe(false);
688688
expect(mockClient.put).toHaveBeenCalled();
689689
});

‎test/emails.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ describe("send", () => {
125125
const emails = new Emails(mockClient);
126126
const { success, error } = await emails.send(fake.send.options);
127127

128-
expect(error).toBeDefined();
128+
expect(error).toBeTruthy();
129129
expect(success).toBe(false);
130130
expect(mockClient.post).toHaveBeenCalled();
131131
});
@@ -156,7 +156,7 @@ describe("checkDomain", () => {
156156
const emails = new Emails(mockClient);
157157
const { results, error } = await emails.checkDomain(fake.checkDomain.options);
158158

159-
expect(error).toBeDefined();
159+
expect(error).toBeTruthy();
160160
expect(results).toBeNull();
161161
expect(mockClient.post).toHaveBeenCalled();
162162
});

‎test/lists.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe("addListEntry", () => {
6161
const lists = new Lists(mockClient);
6262
const { entry, error } = await lists.addListEntry(fake.addListEntry.options);
6363

64-
expect(error).toBeDefined();
64+
expect(error).toBeTruthy();
6565
expect(entry).toBeNull();
6666
expect(mockClient.post).toHaveBeenCalled();
6767
});
@@ -109,7 +109,7 @@ describe("listEntries", () => {
109109
const lists = new Lists(mockClient);
110110
const { entries, error } = await lists.listEntries(fake.addListEntry.options.listName);
111111

112-
expect(error).toBeDefined();
112+
expect(error).toBeTruthy();
113113
expect(entries).toEqual([]);
114114
expect(mockClient.get).toHaveBeenCalled();
115115
});
@@ -154,7 +154,7 @@ describe("deleteListEntry", () => {
154154
const lists = new Lists(mockClient);
155155
const { success, error } = await lists.deleteListEntry(fake.addListEntry.options);
156156

157-
expect(error).toBeDefined();
157+
expect(error).toBeTruthy();
158158
expect(success).toBe(false);
159159
expect(mockClient.delete).toHaveBeenCalled();
160160
});

‎test/service.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ describe("status", () => {
4343
const { success, error } = await service.status();
4444

4545
expect(success).toBe(false);
46-
expect(error).toBeDefined();
46+
expect(error).toBeTruthy();
4747
expect(mockClient.get).toHaveBeenCalled();
4848
});
4949
});
@@ -72,7 +72,7 @@ describe("subscriptions", () => {
7272
const service = new Service(mockClient);
7373
const { subscriptions, error } = await service.subscriptions();
7474

75-
expect(error).toBeDefined();
75+
expect(error).toBeTruthy();
7676
expect(subscriptions).toEqual([]);
7777
expect(mockClient.get).toHaveBeenCalled();
7878
});
@@ -104,7 +104,7 @@ describe("report", () => {
104104
const { success, error } = await service.report(fake.report);
105105

106106
expect(success).toBe(false);
107-
expect(error).toBeDefined();
107+
expect(error).toBeTruthy();
108108
expect(mockClient.post).toHaveBeenCalled();
109109
});
110110
});

‎test/sub-accounts.test.ts‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ describe("create", () => {
127127
const subAccounts = new SubAccounts(mockClient);
128128
const { account, error } = await subAccounts.create(fake.create.validHandle);
129129

130-
expect(error).toBeDefined();
130+
expect(error).toBeTruthy();
131131
expect(account).toBeNull();
132132
expect(mockClient.post).toHaveBeenCalled();
133133
});
@@ -195,7 +195,7 @@ describe("list", () => {
195195
const subAccounts = new SubAccounts(mockClient);
196196
const { accounts, error } = await subAccounts.list();
197197

198-
expect(error).toBeDefined();
198+
expect(error).toBeTruthy();
199199
expect(accounts).toEqual([]);
200200
expect(mockClient.get).toHaveBeenCalled();
201201
});
@@ -239,7 +239,7 @@ describe("delete", () => {
239239
const subAccounts = new SubAccounts(mockClient);
240240
const { success, error } = await subAccounts.delete(fake.create.validHandle);
241241

242-
expect(error).toBeDefined();
242+
expect(error).toBeTruthy();
243243
expect(success).toBe(false);
244244
expect(mockClient.delete).toHaveBeenCalled();
245245
});
@@ -283,7 +283,7 @@ describe("suspend", () => {
283283
const subAccounts = new SubAccounts(mockClient);
284284
const { success, error } = await subAccounts.suspend(fake.create.validHandle);
285285

286-
expect(error).toBeDefined();
286+
expect(error).toBeTruthy();
287287
expect(success).toBe(false);
288288
expect(mockClient.post).toHaveBeenCalled();
289289
});
@@ -327,7 +327,7 @@ describe("activate", () => {
327327
const subAccounts = new SubAccounts(mockClient);
328328
const { success, error } = await subAccounts.activate(fake.create.validHandle);
329329

330-
expect(error).toBeDefined();
330+
expect(error).toBeTruthy();
331331
expect(success).toBe(false);
332332
expect(mockClient.post).toHaveBeenCalled();
333333
});
@@ -370,7 +370,7 @@ describe("createApiKey", () => {
370370
const subAccounts = new SubAccounts(mockClient);
371371
const { key, error } = await subAccounts.createApiKey(fake.create.validHandle);
372372

373-
expect(error).toBeDefined();
373+
expect(error).toBeTruthy();
374374
expect(key).toBeNull();
375375
expect(mockClient.post).toHaveBeenCalled();
376376
});
@@ -414,7 +414,7 @@ describe("listApiKeys", () => {
414414
const subAccounts = new SubAccounts(mockClient);
415415
const { keys, error } = await subAccounts.listApiKeys(fake.create.validHandle);
416416

417-
expect(error).toBeDefined();
417+
expect(error).toBeTruthy();
418418
expect(keys).toEqual([]);
419419
expect(mockClient.get).toHaveBeenCalled();
420420
});
@@ -458,7 +458,7 @@ describe("deleteApiKey", () => {
458458
const subAccounts = new SubAccounts(mockClient);
459459
const { success, error } = await subAccounts.deleteApiKey(fake.create.validHandle, 1);
460460

461-
expect(error).toBeDefined();
461+
expect(error).toBeTruthy();
462462
expect(success).toBe(false);
463463
expect(mockClient.delete).toHaveBeenCalled();
464464
});
@@ -501,7 +501,7 @@ describe("createSmtpPassword", () => {
501501
const subAccounts = new SubAccounts(mockClient);
502502
const { password, error } = await subAccounts.createSmtpPassword(fake.create.validHandle);
503503

504-
expect(error).toBeDefined();
504+
expect(error).toBeTruthy();
505505
expect(password).toBeNull();
506506
expect(mockClient.post).toHaveBeenCalled();
507507
});
@@ -544,7 +544,7 @@ describe("listSmtpPasswords", () => {
544544
const subAccounts = new SubAccounts(mockClient);
545545
const { passwords, error } = await subAccounts.listSmtpPasswords(fake.create.validHandle);
546546

547-
expect(error).toBeDefined();
547+
expect(error).toBeTruthy();
548548
expect(passwords).toEqual([]);
549549
expect(mockClient.get).toHaveBeenCalled();
550550
});
@@ -588,7 +588,7 @@ describe("deleteSmtpPassword", () => {
588588
const subAccounts = new SubAccounts(mockClient);
589589
const { success, error } = await subAccounts.deleteSmtpPassword(fake.create.validHandle, 1);
590590

591-
expect(error).toBeDefined();
591+
expect(error).toBeTruthy();
592592
expect(success).toBe(false);
593593
expect(mockClient.delete).toHaveBeenCalled();
594594
});

‎test/users.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ describe("create", () => {
8282
const users = new Users(mockClient);
8383
const { user, error } = await users.create(fake.create.email);
8484

85-
expect(error).toBeDefined();
85+
expect(error).toBeTruthy();
8686
expect(user).toBeNull();
8787
expect(mockClient.put).toHaveBeenCalled();
8888
});
@@ -143,7 +143,7 @@ describe("addListEntry", () => {
143143
const users = new Users(mockClient);
144144
const { entry, error } = await users.addListEntry(fake.create.email, fake.addListEntry.options);
145145

146-
expect(error).toBeDefined();
146+
expect(error).toBeTruthy();
147147
expect(entry).toBeNull();
148148
expect(mockClient.post).toHaveBeenCalled();
149149
});
@@ -204,7 +204,7 @@ describe("listEntries", () => {
204204
const users = new Users(mockClient);
205205
const { entries, error } = await users.listEntries(fake.create.email, fake.addListEntry.options.listName);
206206

207-
expect(error).toBeDefined();
207+
expect(error).toBeTruthy();
208208
expect(entries).toEqual([]);
209209
expect(mockClient.get).toHaveBeenCalled();
210210
});
@@ -262,7 +262,7 @@ describe("deleteListEntry", () => {
262262
const users = new Users(mockClient);
263263
const { success, error } = await users.deleteListEntry(fake.create.email, fake.addListEntry.options);
264264

265-
expect(error).toBeDefined();
265+
expect(error).toBeTruthy();
266266
expect(success).toBe(false);
267267
expect(mockClient.delete).toHaveBeenCalled();
268268
});

‎test/webhooks.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ describe("enroll", () => {
5959
const webhooks = new Webhooks(mockClient);
6060
const { success, error } = await webhooks.enroll(fake.enroll.endpoint);
6161

62-
expect(error).toBeDefined();
62+
expect(error).toBeTruthy();
6363
expect(success).toBe(false);
6464
expect(mockClient.post).toHaveBeenCalled();
6565
});
@@ -89,7 +89,7 @@ describe("list", () => {
8989
const webhooks = new Webhooks(mockClient);
9090
const { webhooks: webhooksList, error } = await webhooks.list();
9191

92-
expect(error).toBeDefined();
92+
expect(error).toBeTruthy();
9393
expect(webhooksList).toEqual([]);
9494
expect(mockClient.get).toHaveBeenCalled();
9595
});
@@ -120,7 +120,7 @@ describe("delete", () => {
120120
const webhooks = new Webhooks(mockClient);
121121
const { success, error } = await webhooks.delete();
122122

123-
expect(error).toBeDefined();
123+
expect(error).toBeTruthy();
124124
expect(success).toBe(false);
125125
expect(mockClient.delete).toHaveBeenCalled();
126126
});
@@ -149,7 +149,7 @@ describe("getSigningKey", () => {
149149
const webhooks = new Webhooks(mockClient);
150150
const { key, error } = await webhooks.getSigningKey(fake.signingKey.id);
151151

152-
expect(error).toBeDefined();
152+
expect(error).toBeTruthy();
153153
expect(key).toBeNull();
154154
expect(mockClient.get).toHaveBeenCalled();
155155
});

0 commit comments

Comments
 (0)