Bugfix/dropdown hight #365
Conversation
Merged bugfix
|
|
FlorianRappl
left a comment
There was a problem hiding this comment.
LGTM even though something like calc(45vh - 53px) would potentially even be better.
|
(Reason: 10% of VH = unknown, so if the height is smaller than 530px then 40vh will still cut off things; 45vh - 53px takes 45vh as baseline and then subtracts something. So even in the case of a very high screen resolution you'd have some 5% padding + on smaller screens you additionally remove the 53px; making it always fit nicely). |
|
Hallo Florian,
I know that was what we discussed to use "calc(50vh - 53px)"
But after testing multiple dropdowns in the portal.
That was not enough. Specially when the element is on the very upper border (like language list in document center).
So I tried 40, and that was fine. But we definitely needs to run some more tests with different resolutions and pages.
However "45vh - 53px" seems also good.
Best regards
Andreas
|
Yeah that was one proposal @androsssos. However, as mentioned a better solution would be a combination - such as I am not sure what the sweet spot is - because I think a combination of |
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
Dropdown Elements had a height of 50%. Which will lead to a cut view of elements.
Reason is because drowdown has a top:-53px.
This fix changed it to 40% to be on the save side and to make sure that the drowdown is not out of the screen on the top