Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@panichevoleg
Copy link
Contributor

@panichevoleg panichevoleg commented Mar 16, 2022

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

Accoring to WCAG 2 validator, there is Empty table header error.

What does the Empty Table Header error mean?

An empty table header error means that one of the table headers on your post or page does not contain any text. This means that the <th> element is present but looks like this <th></th> with nothing between the opening and closing tags.

How to Fix It

If the table cell is a header, provide text within the cell that describes the column or row. If the cell is not a header or must remain empty (such as the top-left cell in a data table), make the cell a <td> rather than a <th>.

So, if <th></th> is empty, I render it as <td></td> (styling kept the same).

@panichevoleg panichevoleg force-pushed the bugfix/648843-table-wrong-header branch from 681c888 to 01d23e8 Compare March 16, 2022 16:08
Copy link
Collaborator

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great job!
🍻

@FlorianRappl FlorianRappl merged commit a96f795 into ZEISS:main Mar 17, 2022
@panichevoleg panichevoleg deleted the bugfix/648843-table-wrong-header branch March 17, 2022 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants