Rewrite GPU Line Algorithm #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a demonstration of the new line-rendering algorithm: |
|
looks good so far, but i'm not familiar with the gpu stuff, maybe @SwissalpS could take a look? |
SwissalpS
reviewed
Jun 28, 2025
SwissalpS
reviewed
Jun 28, 2025
|
Thanks for bringing better algo to this mod :D This PR seems fine except lines 423 to 434 which don't seem to add anything. |
|
Works for me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the GPU line rendering code to use Bresenham's algorithm, and a modified version of that to draw higher quality antialiased lines. The command syntax is no different.