Thanks to visit codestin.com
Credit goes to github.com

Skip to content

De-bundle unspecific stuff #146

@Athozus

Description

@Athozus

Yo,

I initially planned this in my mind for 1.5.0, but as 1.4.0 is getting more and more "late" (that's a volunteer project at all), so I'm opening the issue right now and I did not set a milestone, to be discussed.

IMHO, we should the following stuff :

  • GUI helpers
    • Name : maybe a combination of "GUI" and "Util" => guitil ? (idk, that's not important lol)
    • Depends : none
    • Stuff to be moved :
      • util/colors.lua
      • Some custom widgets like the highlighted box (using in settings/about)
      • util/time_ago.lua (used in Date tooltip) ?
    • Interaction :
      • modname.get_color("color") actual function
      • modname.get_color({"color1", "color2"}) actual function
      • modname.insert_widget() => could returns a formspec-escaped for "custom" widgets like highlighted box.
  • Settings
    • Name : simply settings, or to not be too restrictive something like settingz ?
    • Depends : GUI helpers just above
    • Stuff to be moved :
      • ui/settings.lua
      • Few components of util/settings.lua
      • Way it stores in storage.lua
    • Interaction :
      • modname.register_setting(dictionary)
      • modname.register_settings(list of dictionaries)
      • modname.get_setting(name, "setting") exactly like mail.get_setting()
      • modname.set_setting(name, "setting", value) exactly like mail.set_setting()
      • modname.reset_settings(modname)

All those dependencies of mail mod, all managed by mt-mods, and for all I assume the "unofficial" role of (co-)maintainer.

Metadata

Metadata

Assignees

Labels

CleanupCleanup of bad code or other redundant/unnecessary stuffHelp wantedExtra attention is needed

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions