Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[charts] Make new hideLegend prop on ChartWrapper optional #19694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2025
Merged

[charts] Make new hideLegend prop on ChartWrapper optional #19694

merged 2 commits into from
Sep 25, 2025
+8 −6

Conversation

@thomas-mcdonald
Copy link
Contributor

I am using composition for some of our more complicated charts and #19257 introduced a new required prop on ChartWrapper which broke our build. I have made this optional with a false default, which seems reasonable to me?

@bernardobelchior bernardobelchior added type: bug It doesn't behave as expected. scope: charts Changes related to the charts. labels Sep 24, 2025
bernardobelchior
bernardobelchior approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@bernardobelchior bernardobelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This was an oversight, thank you for the fix 😄

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19694 will not alter performance

Comparing thomas-mcdonald:show-legend-optional (a567359) with master (5cfb210)1

Summary

✅ 12 untouched

Footnotes

  1. No successful run was found on master (96d76fa) during the generation of this report, so 5cfb210 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@mui-bot
Copy link

mui-bot commented Sep 24, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19694--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) ▼-6B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) ▼-4B(0.00%)
@mui/x-charts 🔺+6B(0.00%) 🔺+3B(0.00%)
@mui/x-charts-pro 🔺+6B(0.00%) 🔺+1B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) ▼-4B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) ▼-3B(-0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against a567359

@thomas-mcdonald
Copy link
Contributor Author

@bernardobelchior sorry, I missed the lint step locally, have pushed an update to resolve

@JCQuintas JCQuintas enabled auto-merge (squash) September 24, 2025 22:57
@JCQuintas JCQuintas disabled auto-merge September 24, 2025 22:57
@JCQuintas JCQuintas merged commit 1c5529b into mui:master Sep 25, 2025
22 checks passed
@JCQuintas JCQuintas mentioned this pull request Sep 25, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JCQuintas JCQuintas JCQuintas approved these changes

@bernardobelchior bernardobelchior bernardobelchior approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette alexfauquette is a code owner

Assignees

No one assigned

Labels

scope: charts Changes related to the charts. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thomas-mcdonald @mui-bot @JCQuintas @bernardobelchior