-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[DataGridPremium] Exceljs fork #19796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview: https://deploy-preview-19796--material-ui-x.netlify.app/ Bundle size report
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
e35016b to
1b70151
Compare
1b70151 to
2b538c3
Compare
| "date-fns-jalali": "catalog:", | ||
| "dayjs": "catalog:", | ||
| "es-toolkit": "^1.40.0", | ||
| "exceljs": "catalog:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to declare it in the docs' dependencies
2b538c3 to
a451c66
Compare
|
@cherniavskii can you give access to the private fork repo to the MUI members? |
|
@arminmeh Done, everyone in the org should have the access now |
|
Nice work 👏🏻 |
Closes #13267
Replaces
exceljsdependency of the@mui/x-data-grid-premiumpackage with@mui/x-internal-exceljs-forkpackage – MUI's private fork that addresses security and licensing issues.Changes
unzipperhttps://github.com/mui/mui-fork-exceljs/commit/38724a077dcb546418ac657a1155abd34053a7ecFixes Request to bump version of unzipper to eliminate license concerns exceljs/exceljs#2743
Fixes [data grid] Replace ExcelJS #13267 (comment)
archiverhttps://github.com/mui/mui-fork-exceljs/commit/ee313e09fc6a6acb23b56718fe9da09d40ff4e0eFixes [data grid] Snyk warning for inflight through exceljs #13187
Fixes [data grid] Synk Vulnerability #12887
Fixes [data grid] Snyk warning for inflight through exceljs #13187 (comment)
Fixes issues like Getting 'sharredString's when trying to parse XSLX in the streaming mode exceljs/exceljs#683, which do not impact us directly, but I wanted to have a green test suite for stability.
Demos