Adds ability to use any Laravel model as Chat participant #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonj
reviewed
Oct 14, 2019
simonj
reviewed
Oct 25, 2019
simonj
reviewed
Oct 25, 2019
9d02067 to
44a29e2
Compare
b92b49f to
e1dd24d
Compare
fae3000 to
8e485c1
Compare
…into model-transformers
* Adding data transformers * Apply fixes from StyleCI (#201) * Adding data transformers
simonj
approved these changes
Nov 1, 2019
Owner
Author
|
Thanks @simonj I feel there is a little more cleanup to do before release. You can use the candidate release here https://github.com/musonza/chat/releases/tag/v4.0.0-rc4. Nothing major will change for |
|
Thanks a lot! will try that tonight after work. are you on discord in the Laravel channel :)? Would love to chat |
Owner
Author
|
@simonj yes I am look for |
simonj
reviewed
Nov 2, 2019
simonj
reviewed
Nov 2, 2019
Owner
Author
|
Thanks I will test with that
…On Sun, Nov 3, 2019 at 4:01 PM Simon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Models/Conversation.php
<#163 (comment)>:
> + return $paginator
+ ->orderBy('c.updated_at', 'DESC')
+ ->orderBy('c.id', 'DESC')
+ ->distinct('c.id')
Am using mysql 8.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#163?email_source=notifications&email_token=AA2K3ZEYWCYISYDB32MI2W3QR432NA5CNFSM4I52C3YKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKDQO3I#discussion_r341872205>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2K3ZEPXJ3PXWOUWH4UAPDQR432NANCNFSM4I52C3YA>
.
|
|
I can't find you on discord btw :P Can you add me |
…a/chat into multiple-model-recipients
Owner
Author
|
@simonj try the new candidate release and let me know if it works. Also i have added you on discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Demo
https://github.com/musonza/chat-demo/tree/multiple-model-recipients
Release Candidate
https://github.com/musonza/chat/releases/tag/v4.0.0-rc6