Also search for STIX2 files in directories in MVT_STIX2 #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roaree
approved these changes
Sep 10, 2024
mvt/common/indicators.py
Outdated
Comment on lines
52
to
55
| if os.path.isdir(path): | ||
| for root, dirs, files in os.walk(path): | ||
| for filename in files: | ||
| if filename.lower().endswith(".stix2"): |
There was a problem hiding this comment.
Non-blocker: we might have some examples of using glob that could condense this into one for loop
There was a problem hiding this comment.
happy to change that if you can show me an example.
There was a problem hiding this comment.
I think he means something like this using the glob library
There was a problem hiding this comment.
I think he means something like this using the glob library
Yes exactly. The glob makes it easier to rationalise about what the code is doing IMO.
There was a problem hiding this comment.
I changed the code to use glob.glob instead.
note: this is case-sensitive now. Case insensitivity with glob was only added in python3.12
DonnchaC
added a commit
that referenced
this pull request
Oct 16, 2024
* also search for STIX2 files in directories in MVT_STIX2 * update datetime deprecations * add variable declaration in __init__ * add str to return typed in cmd_download_apks.py * change dictionary creations to dictionary literals * replace call to set() with set literal * fix incorrect docstrings * remove whitespace according to PEP8: E203 * remove whitespace according to PEP8: E203 * remove unreachable return statement * use Union[] instead of | operator for python 3.8/9 compatability * Fix ruff formating of files * Revert "also search for STIX2 files in directories in MVT_STIX2" This reverts commit 287a11a. We have this change as a seperate PR in #527. --------- Co-authored-by: Janik Besendorf <[email protected]> Co-authored-by: Donncha Ó Cearbhaill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version of this method only accepted paths to files in MVT_STIX2. This new version checks whether a variable in MVT_STIX2 is a file or a dir and then recursively searches for .stix2 files in those dirs.
A change I made is that it only processes .stix2 files which I thought is a reasonably check.