Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kbudde
Copy link
Member

@kbudde kbudde commented Jan 12, 2024

closes #215

@codecov
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dee31a0) 48.55% compared to head (4b2c260) 48.55%.

Files Patch % Lines
internal/myks/environment.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #216   +/-   ##
=======================================
  Coverage   48.55%   48.55%           
=======================================
  Files          30       30           
  Lines        2587     2587           
=======================================
  Hits         1256     1256           
  Misses       1145     1145           
  Partials      186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zebradil Zebradil changed the title fix: proceed with deletion if file does not exist fix: don't fail on attempt to clean up non existing files Jan 12, 2024
@Zebradil Zebradil merged commit 5a20896 into dev Jan 12, 2024
@Zebradil Zebradil deleted the dont_fail_on_deleting_non_existing_file branch January 12, 2024 14:29
mykso-bot added a commit that referenced this pull request Jan 12, 2024
## [3.2.2](v3.2.1...v3.2.2) (2024-01-12)

### Bug Fixes

* **deps:** update golang.org/x/exp digest to 0dcbfd6 ([#213](#213)) ([dee31a0](dee31a0))
* **deps:** update golang.org/x/exp digest to db7319d ([#217](#217)) ([69e3a30](69e3a30))
* don't fail on attempt to clean up non existing files ([#216](#216)) ([5a20896](5a20896))
This was referenced Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing app as it is not configured fails if ArgoCD is disabled

3 participants