fix an infinite loop when the token dispenser is having issues #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When searching or downloading apks, gplaycli will happily keeping to get a token over and over from the token dispenser. If the token dispenser spits out tokens but google doesn't like them, it will create an infinite loop. This breaks out of that loop after 5 attempts, and also suggest to the user that they try using their own credentials. I'd like to point them to a manpage or README with instructions, but we're not there yet.
|
As a user, this would be great to have! Maybe it should be enabled using a option flag? Make the default be the current behavior, then it would be something like |
|
Worked for me ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching or downloading apks, gplaycli will happily keeping to
get a token over and over from the token dispenser. If the token
dispenser spits out tokens but google doesn't like them, it will
create an infinite loop.
This breaks out of that loop after 5 attempts, and also suggest to
the user that they try using their own credentials. I'd like to
point them to a manpage or README with instructions, but we're
not there yet.