This repository was archived by the owner on Jul 21, 2025. It is now read-only.
Initialise sygnal_inflight_request_limit_drop before it's incremented #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the metric is null until a request is dropped, which may not happen for a while (ideally never).
|
I think this just needs to run |
|
I think black and flake8 are fighting? :) Might want to check our synapse config for flake8 and copy it over. |
I'll do that in a separate PR. This one should be good to review now. Interestingly in Synapse we disable long line checks in flake8, though black seemed perfectly happy to include a 100+ char line. So there's probably some |
clokep
approved these changes
Mar 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sygnal_inflight_request_limit_dropis a Counter that counts how many requests were dropped due to a pushkin hitting its concurrent request limit, and was added in #146.A quirk of counter metrics with a label is that they will not show up in prometheus until they are initially referenced. This had the side-effect of not being able to easily monitor/alert on the metric until something actually went wrong
This PR references and sets up a instance variable with the pushkin's name as a label immediately, ensuring it appears as 0 in prometheus upon startup.