Remove temporary trip Id from LRTP TripUpdates #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
huangh
approved these changes
Nov 10, 2025
Collaborator
|
you beat me to this by minutes..lol. i edited the description to be more accurate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task: https://app.asana.com/1/15492006741476/project/1210964140773280/task/1211899931911282?focus=true
Reverts temporary trip_id change introduced here for LRTP: #563
What changes does this PR propose?
Removes the
trip_idthat we generated, reinstating the original from GTFS-RTHow were these changes validated?
run_parquet_hyper_lampforHyperDevGreenGtfsRtTripUpdates(yes, the whole thing), saw that the files had been createdWhat questions should reviewers consider?
None.