Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jay-oswald
Copy link
Collaborator

  • cleanup vehicle profiles action, remove un-necesary parts, comitting everything, as some paths are dynamic. Anything we touch should be comitted anyway
  • Adding extends to vehicle profiles, so profiles can extend other profiles (at any depth)
  • Writing the main vehicle_profiles.json in pretty format instead of compressed. Its only ever read by browser on wican, or manually. So the extra readibility is much better than slightly smaller size now, makes debugging much easier
  • Fixing title for supported vehicles docs page
  • Adding Kona profile, as example of extends

@jay-oswald jay-oswald requested a review from meatpiHQ as a code owner September 7, 2025 12:12
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

✅ Vehicle profiles merged successfully!

Please download and test the updated vehicle_profiles.json.

@jay-oswald
Copy link
Collaborator Author

@meatpiHQ if you can give the updated vehicle_profiles file a test, done lots of changes, however pretty confident its all good.

Would be good to do stuff like have a generic ICE profile that all cars are based off, so that Generic profile can be used as base for any ICE car, as long as it contains standard PID's etc. As well as other bases for any other standard/common things

@meatpiHQ
Copy link
Owner

meatpiHQ commented Sep 7, 2025

i think there are some issues in the vehicle_profiles

here are some examples
image

image

@jay-oswald
Copy link
Collaborator Author

@meatpiHQ I think the vehicle profiles look good to me, it seams to just have trouble doing the compare for some reason with this change.

Also is pid_init used at all? I seam to remember its not used/needed at all? If thats the case may be a good time to just delete it completly from all profiles?

@meatpiHQ
Copy link
Owner

@jay-oswald the pid_init is important and used, we cannot drop it.

To compare the changes use any json formatter on both profiles

@jay-oswald
Copy link
Collaborator Author

@meatpiHQ merging this one, I can't see any differences doing the diff, excpet ones I've introduced by making the minor changes, like making Kona have its own profile. Will let it build the new version and confirm it after merge

@jay-oswald jay-oswald merged commit 6ba75e6 into main Sep 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants