Fixes the issue that line gap may ruin the text layout. #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How will this affect how western multiline text is rendered? i.e. the nanovg demo. |
|
This doesn't affect western multiline at all. PS. In my previous PR of fixing font size, the font size now matches what you saw on other native apps. The font used by the demo was affected by this because the font sizes were set to a value bigger than they actually were. I'm still fixing the font sizes and will submit another PR later. |
|
Just submitted a PR to fix demo's font size. #564 The result looks exactly the same with or without this PR's changes of fixing the line gap issue. BEFORE: AFTER: |
|
Thanks for the fix! |
|
Thanks for the quick merging. Cheers! 🥂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS uses the
Hiragino Sansfont as the default Japanese font. However, this font abuses theline gapproperty like many fonts.line gapas theline height.line gapto 200.Back to the
Hiraginofont. The font family always setsline gapto 500 no matter what while thefont height (ascent - descent)is only 1000. Which causes the spaces between lines are super big.As mentioned here https://stackoverflow.com/questions/5414730/custom-installed-font-not-displayed-correctly-in-uilabel, Apple ignores the
line gapproperty since iOS 7, and a workaround to fix this issue is to add theline gapto theascentand we'll be fine to ignore theline gapproperty. Now the result looks much normal.This change doesn't affect the alignment, either.