Added: Text rotate [#80] #240
Conversation
| * | ||
| * @return float clockwise rotation | ||
| */ | ||
| public function rotation(): float |
There was a problem hiding this comment.
I think this should be called getRotation(), so that there is less potential to confuse it with rotate(), and so it starts with a verb (like most functions besides convenience attribute accessors do).
| protected function prepareRenderParams(array $options, Transform $transform, ?FontRegistry $fontRegistry): ?array | ||
| { | ||
| // this assumes there is no rotation or skew, but that's fine, we can't deal with that anyway | ||
| // only the rotational impact of skew is used |
There was a problem hiding this comment.
I would imagine skew has no impact on the rotation? In that case, maybe reword it:
| // only the rotational impact of skew is used | |
| // Only the rotational component of the transform is used |
There was a problem hiding this comment.
Skew does impact rotation, for example, use -1 and 1 here in skew: https://angrytools.com/css-generator/transform/
But your wording better in both cases, so I'll use that ;)
| $y = $options['y']; | ||
| $transform->map($x, $y); | ||
|
|
||
| //get clockwise rotation result from transform matrix |
There was a problem hiding this comment.
(nitpick)
| //get clockwise rotation result from transform matrix | |
| // get clockwise rotation from transform matrix |
| 'size' => $size, | ||
| 'fontPath' => $fontPath, | ||
| 'text' => $options['text'], | ||
| 'rotation' => $rotation |
There was a problem hiding this comment.
(nitpick)
| 'rotation' => $rotation | |
| 'rotation' => $rotation, |
|
|
||
| $caRadian = atan2(-$this->matrix[2], $this->matrix[0]); | ||
| $bdRadian = atan2($this->matrix[1], $this->matrix[3]); | ||
| return ($caRadian + $bdRadian) / 2 * 180 / M_PI; |
There was a problem hiding this comment.
Since rotate() uses radians, this should return radians as well, and leave the conversion up to the caller.
|
@daanggc Would you be able to incorporate the feedback into your PR when you have some time? I'll try to add some tests for your work soon—just need to find the time! |
Added: Text rotate [#80]
Text rotation was added by calculating the resulting rotation after all transformations were calculated.
So we are using the resulting matrix data in the
Transformto get our final rotation.The
rotationfunction in theTransformclass is universal, so it should be usable for other elements.