Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove tick label conversion #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2025
Merged

Remove tick label conversion #326

merged 3 commits into from
Aug 25, 2025

Conversation

@rgieseke
Copy link
Contributor

@rgieseke rgieseke commented Aug 19, 2025

Error was

`/layercake/src/routes/_examples/Histogram.svelte:56:61
Error: Type '(d: any) => number' is not assignable to type '(d: any) => string'.
  Type 'number' is not assignable to type 'string'. (js)
		<Svg>
			<AxisX gridlines={false} baseline ticks={slimThresholds} format={d => +f(d)} />

/layercake/src/routes/_examples_ssr/Histogram.svelte:52:56
Error: Type '(d: any) => number' is not assignable to type '(d: any) => string'.
  Type 'number' is not assignable to type 'string'. (js)
		<Html>
			<AxisX gridlines={false} baseline ticks={slimSteps} format={d => +f(d)} />

This PR removes the conversion to number.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025

🎭 Playwright tests failed

The Playwright tests failed on this PR. Please check the test results and fix any issues.

📊 View full test report

@rgieseke
Copy link
Contributor Author

rgieseke commented Aug 19, 2025

Seems it does make a difference in the formatting, e.g. 1.6 vs 1.60. I'll run the update snapshot workflow for this branch.

@mhkeller
Copy link
Owner

mhkeller commented Aug 23, 2025

Let's do String(+f(d)) to preserve the formatting but keep it as a string type.

@rgieseke rgieseke force-pushed the remove-extra-conversion branch from 019eadc to a3437d2 Compare August 24, 2025 19:49
@rgieseke
Copy link
Contributor Author

rgieseke commented Aug 24, 2025

Let's do String(+f(d)) to preserve the formatting but keep it as a string type.

Done!

@mhkeller mhkeller merged commit 3c1f591 into mhkeller:main Aug 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rgieseke @mhkeller