Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix expansion of "floating" WASM variables in repl/watch + readMemory when WASM memory is SharedArrayBuffer #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

Fix expansion of "floating" WASM variables in repl/watch + readMemory when WASM memory is SharedArrayBuffer #2199

merged 2 commits into from
Apr 8, 2025

Conversation

@mikaelwaltersson
Copy link
Contributor

@mikaelwaltersson mikaelwaltersson commented Apr 8, 2025

This PR includes bug fixes for the following issues:

  • When debugging WebAssembly modules if you use the Watch or REPL to view values only the top level value will be shown, any value with children will not be viewable.
  • The memory viewer does not work if the WebAssembly memory is backed by a SharedArrayBuffer

Screenshot of current behavior using the REPL to view a variable with children:
c-wasm-app-debugging-not-working

Screenshot of behavior when running this PR version:
c-wasm-app-debugging

Example code used in the the screenshots:
c-wasm-app.zip

@mikaelwaltersson
Copy link
Contributor Author

mikaelwaltersson commented Apr 8, 2025

@mikaelwaltersson please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

connor4312
connor4312 approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you! 👏

@connor4312 connor4312 enabled auto-merge (squash) April 8, 2025 16:52
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 8, 2025
@connor4312 connor4312 merged commit 1942fd6 into microsoft:main Apr 8, 2025
5 of 7 checks passed
@mikaelwaltersson mikaelwaltersson deleted the fix-floating-wasm-variable branch April 8, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connor4312 connor4312 connor4312 approved these changes

@lramos15 lramos15 lramos15 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

April 2025

Development

Successfully merging this pull request may close these issues.

3 participants

@mikaelwaltersson @connor4312 @lramos15