Fix gvfs clone version check when revision is included in the version string
#1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not _any_ version that starts with `0.` that is a development version, instead it is the version hard-coded in `Version.props` when no `GVFSVersion` has been specified. Signed-off-by: Johannes Schindelin <[email protected]>
In .NET SDK 8, the Informational Version attribute of the assembly includes the commit ID of the current HEAD at build time: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/source-link This kind of version might be compliant with SemVer v2.0, but it is _not_ System.Version-compliant. Therefore, we opted out of this new behavior _really quickly_ after upgrading from SDK 3 to SDK 9, in order to fix cloning from repositories where `gvfs/config` requires certain minimal VFSforGit versions. In this here commit, we adapt the logic to strip off the commit ID if present. That way, the version check would continue to work even if we opted back in to this new behavior that includes the commit SHA in `gvfs version`'s output. Signed-off-by: Johannes Schindelin <[email protected]>
mjcheetham
reviewed
Sep 18, 2025
mjcheetham
approved these changes
Sep 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @tyrielv,
gvfs clonewould fail with https://github.com/microsoft/VFSForGit/releases/tag/v1.0.25260.1 when the repository to clone specifies a minimal VFSforGit version in itsgvfs/configendpoint. The reason is that with the version bump from .NET SDK v3 to v9, the version string included in the assembly now contains the suffix+<commit-SHA>, which cannot be parsed bySystem.Version:@mjcheetham provided a quick work-around in #1870 to opt out of the new behavior and report the version without that suffix again; Here is a PR that prepares the code to handle such versions gracefully, to open up the door to opt back in to the new behavior (and let
gvfs versionreport an even more informative output than right now).