Replace normal builds with trimmed single-file builds #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallipr
reviewed
Sep 11, 2025
Member
|
blocking-release for 0.6.0 today |
hallipr
reviewed
Sep 11, 2025
6f60b3e to
4b64571
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default build behavior from producing normal builds to producing trimmed single-file builds, implementing a decision to default to trimming for better performance and deployment characteristics.
- Updated the build pipeline to include trimming and single-file publishing flags by default
- Modified Directory.Build.props to apply TrimMode=Full globally instead of only for native builds
- Disabled native builds in the release pipeline to focus on the new trimmed build approach
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/templates/jobs/build.yml | Added -Trimmed and -SingleFile flags to the Build-Module.ps1 command |
| eng/pipelines/templates/common.yml | Changed IncludeNative parameter from dynamic to hardcoded false |
| Directory.Build.props | Moved TrimMode=Full to global scope and removed duplicate from native build section |
4b64571 to
e351041
Compare
hallipr
approved these changes
Sep 11, 2025
joshfree
approved these changes
Sep 11, 2025
weshaggard
approved these changes
Sep 11, 2025
weshaggard
reviewed
Sep 11, 2025
weshaggard
reviewed
Sep 11, 2025
Member
Member
|
|
c77174c to
49f4271
Compare
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]Following internal team discussion and agreement to move forward with defaulting to trimming:
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline