Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@msalaman
Copy link
Contributor

What does this PR do?

Move bicep from Native AOT build module exclusion, should pass now that we update bicep type versions

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the bicep schema module from the Native AOT build exclusion list back into the main module registration list. This change enables the bicep schema functionality to be included in AOT builds after updating bicep type versions to be AOT-compatible.

  • Move bicep schema module from conditional exclusion to standard registration
  • Remove bicep schema from Native AOT build exclusion block

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server Sep 11, 2025
@joshfree joshfree added the tools-bicep Bicep code generation label Sep 11, 2025
@joshfree joshfree added this to the 2025-09 milestone Sep 11, 2025
@joshfree joshfree enabled auto-merge (squash) September 11, 2025 18:37
@joshfree
Copy link
Member

LGTM, thank you @msalaman

@joshfree joshfree merged commit bb82331 into main Sep 11, 2025
23 checks passed
@joshfree joshfree deleted the masalama/RemoveAOTExceptionForBicep branch September 11, 2025 19:39
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Sep 11, 2025
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Sep 27, 2025
move bicep from Native AOT build module exclusion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools-bicep Bicep code generation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants