Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Path and Tool parameters to DeployTestResources #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 3, 2025
Merged

Add Path and Tool parameters to DeployTestResources #68

merged 11 commits into from
Sep 3, 2025

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Aug 27, 2025 •
edited
Loading

What does this PR do?

Deploy-TestResources wasn't updated to support the new tools/ paths.
This changes the parameter from 'Area' to 'Tool' and 'Path'.

Deploy-TestResources.ps1 -Path Azure.Mcp.Tools.*
Deploy-TestResources.ps1 -Path storage
Deploy-TestResources.ps1 -Path core/Azure.Mcp.Core

GitHub issue number?

fixes #38

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
    • Spelling check passes: .\eng\common\spelling\Invoke-Cspell.ps1
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated README.md documentation
    • Updated command list in /docs/azmcp-commands.md
    • Updated test prompts in /docs/e2eTestPrompts.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • 👉 For Community (non-Azure team member) PRs:
    • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
    • Manual tests run: added comment /azp run azure - mcp to run Live Test Pipeline

Copilot AI review requested due to automatic review settings August 27, 2025 18:46
@hallipr hallipr requested a review from a team as a code owner August 27, 2025 18:46
Copilot AI reviewed Aug 27, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Deploy-TestResources.ps1 script to support the new tools-based directory structure by replacing the single Area parameter with two mutually exclusive parameter sets: Path (for direct path specification) and Tool (for tool-based deployment with partial matching). The changes include enhanced error handling and backward compatibility considerations.

Key changes:

  • Replaced single Area parameter with Path and Tool parameter sets for flexible resource deployment
  • Added intelligent tool matching with partial name support and clear error messages
  • Updated documentation to reflect the new parameter structure and usage patterns

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
eng/scripts/Deploy-TestResources.ps1 Refactored parameter structure from single Area to Path/Tool parameter sets with enhanced tool discovery logic
CONTRIBUTING.md Updated documentation to reflect new directory structure, parameter usage, and deployment examples

@hallipr hallipr force-pushed the users/pahallis/deploy-testresources branch from 3daa837 to fadbfeb Compare August 27, 2025 18:46
@hallipr hallipr enabled auto-merge (squash) August 27, 2025 19:49
vcolin7
vcolin7 reviewed Aug 27, 2025
View reviewed changes
weshaggard
weshaggard reviewed Aug 28, 2025
View reviewed changes
weshaggard
weshaggard reviewed Aug 28, 2025
View reviewed changes
@jairmyree jairmyree mentioned this pull request Aug 29, 2025
Merged
weshaggard
weshaggard approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like this to support multiple tools but that can come as a follow-up. We need to get this in so folks can run any local tests.

@hallipr hallipr force-pushed the users/pahallis/deploy-testresources branch from 0cabe2a to 9b536cb Compare September 3, 2025 16:03
@hallipr hallipr requested a review from a team as a code owner September 3, 2025 16:03
weshaggard
weshaggard reviewed Sep 3, 2025
View reviewed changes
@hallipr
Copy link
Member Author

hallipr commented Sep 3, 2025

/azp run mcp - pullrequest - live

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 3, 2025

Azure Pipelines successfully started running 1 pipeline(s).

weshaggard
weshaggard reviewed Sep 3, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this to Untriaged in Azure MCP Server Sep 3, 2025
@hallipr hallipr merged commit 8b032e9 into main Sep 3, 2025
25 checks passed
@hallipr hallipr deleted the users/pahallis/deploy-testresources branch September 3, 2025 22:17
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure MCP Server Sep 3, 2025
@ericshape
Copy link
Member

ericshape commented Sep 5, 2025 •
edited
Loading

Hi @hallipr could we update the https://github.com/microsoft/mcp/blob/main/CONTRIBUTING.md to reflect Areas -> Paths/Members change for the live test command?
It seems that we have retired the "Areas" concept in this repo? Thanks~

I drafted this PR #326 but I am not sure it has been covered all cases

This was referenced Sep 5, 2025
Merged
Closed
feiskyer pushed a commit to feiskyer/microsoft-mcp that referenced this pull request Sep 8, 2025
@jongio
Refactor JSON handling in tests to access 'results' property directly (…
ef7aac0 
…microsoft#68)
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Sep 27, 2025
@hallipr @colbytimm
Add Path and Tool parameters to DeployTestResources (microsoft#68)
7112fbe
@hallipr hallipr linked an issue Oct 7, 2025 that may be closed by this pull request
MQ: Update Deploy-TestResources.ps1 to include an All Area and Multiple Areas at once #290
Closed
@hallipr hallipr mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcolin7 vcolin7 vcolin7 left review comments

Copilot code review Copilot Copilot left review comments

@weshaggard weshaggard weshaggard approved these changes

@wbreza wbreza Awaiting requested review from wbreza wbreza is a code owner automatically assigned from microsoft/azure-mcp

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from microsoft/azure-mcp

@conniey conniey Awaiting requested review from conniey conniey is a code owner automatically assigned from microsoft/azure-mcp

@tmeschter tmeschter Awaiting requested review from tmeschter tmeschter is a code owner automatically assigned from microsoft/azure-mcp

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner automatically assigned from microsoft/azure-mcp

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner automatically assigned from microsoft/azure-mcp

@fanyang-mono fanyang-mono Awaiting requested review from fanyang-mono fanyang-mono is a code owner automatically assigned from microsoft/azure-mcp

+1 more reviewer

@slin75 slin75 slin75 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Azure MCP Server
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MQ: Update Deploy-TestResources.ps1 to include an All Area and Multiple Areas at once [Azure-MCP] Deploy-TestResources.ps1 points to old repo path

6 participants

@hallipr @ericshape @vcolin7 @weshaggard @slin75