Re-enable smoke tests #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables smoke tests in the CI pipeline by removing a condition that was causing them to be skipped. The primary motivation is to allow smoke tests to run consistently across all builds, rather than being conditionally skipped based on the RunUnitTests variable and ARM64 architecture concerns.
Key Changes:
- Removed conditional execution logic that was skipping smoke tests on ARM64 machines
- Simplified the smoke test execution by removing the
WorkingDirectoryparameter and condition check
weshaggard
approved these changes
Oct 27, 2025
hallipr
reviewed
Oct 27, 2025
hallipr
approved these changes
Oct 27, 2025
joshfree
approved these changes
Oct 27, 2025
Member
|
Please port this to /release/azure/1.x |
vcolin7
added a commit
that referenced
this pull request
Oct 28, 2025
* Add instructions on when to not use azd init (#942) * Add instrunctions on when to not use azd init * Update CHANGELOG * Address review feedback * Refactored ToolDescriptionEvaluator code and added more options (#899) * Renamed --validate to --test-single-tool * Refactored Program.cs to remove duplicated tool loading logic * Updated error message logic * Refactored error handling and updated exceptions thrown * Added new --server and --server-exe args and enhanced error handling for missing files and invalid arguments * Updated docs * Fixed syntax errors * Removed azmcp_ prefix from e2eTestPrompts.md * Fixed more issues * Ran TDE * Fixed parameter validation * Updated more usre-facing messages * Updated docs and --help command info * Small doc update * Removed file added by accident. * Renamed header in README * Applied some PR feedback * Applied more PR feedback * Updated logs * Fixed formatting * Merge release branch after `0.9.8` release (#948) * Updated CHANGELOGs for 0.9.8 release * Increment version after release (#946) * Increment package version after release * Add release branch to pull request pipeline --------- Co-authored-by: Wes Haggard <[email protected]> --------- Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Adds ToolArea and ToolName to single mode telemetry. (#952) * Make registry error message more descriptive. * Set ToolArea and ToolName in single proxy mode. * Update CHANGELOG. * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Update CHANGELOG --------- Co-authored-by: Copilot <[email protected]> * Adding CELA approved warnings in README (#955) * Adding CELA approved warnings * Update servers/Azure.Mcp.Server/README.md Co-authored-by: Copilot <[email protected]> * removing localization in docs link --------- Co-authored-by: Copilot <[email protected]> * Updating ToC of Azure MCP readme (#968) * Adding CELA approved warnings * Update servers/Azure.Mcp.Server/README.md Co-authored-by: Copilot <[email protected]> * removing localization in docs link * Updating ToC on Readme --------- Co-authored-by: Copilot <[email protected]> * Fix broken links in README (#979) * Add installation GIF for Azure MCP Server extension in README (2nd attempt) (#978) * Add installation GIF for Azure MCP Server extension in README * Update servers/Azure.Mcp.Server/README.md Co-authored-by: Copilot <[email protected]> * Fix typo in remove-section markers in Azure.Mcp.Server README --------- Co-authored-by: Copilot <[email protected]> * Re-enable smoke tests (#981) Enable smoke tests * Prepare `1.0.0` release * Fix README image reference and rename the gif (#983) Add the install_azure_mcp_server_extension.gif asset and update README to reference the new filename (use underscores instead of dashes). --------- Co-authored-by: Fan Yang <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Sandeep Sen <[email protected]> Co-authored-by: Vinay Gera <[email protected]> Co-authored-by: Chris Harris <[email protected]>
weshaggard
added a commit
that referenced
this pull request
Oct 29, 2025
* Updated CHANGELOGs for 0.9.8 release * Increment version after release (#946) * Increment package version after release * Add release branch to pull request pipeline --------- Co-authored-by: Wes Haggard <[email protected]> * Prepare version `0.9.9` release (#956) * Add instructions on when to not use azd init (#942) * Add instrunctions on when to not use azd init * Update CHANGELOG * Address review feedback * Refactored ToolDescriptionEvaluator code and added more options (#899) * Renamed --validate to --test-single-tool * Refactored Program.cs to remove duplicated tool loading logic * Updated error message logic * Refactored error handling and updated exceptions thrown * Added new --server and --server-exe args and enhanced error handling for missing files and invalid arguments * Updated docs * Fixed syntax errors * Removed azmcp_ prefix from e2eTestPrompts.md * Fixed more issues * Ran TDE * Fixed parameter validation * Updated more usre-facing messages * Updated docs and --help command info * Small doc update * Removed file added by accident. * Renamed header in README * Applied some PR feedback * Applied more PR feedback * Updated logs * Fixed formatting * Merge release branch after `0.9.8` release (#948) * Updated CHANGELOGs for 0.9.8 release * Increment version after release (#946) * Increment package version after release * Add release branch to pull request pipeline --------- Co-authored-by: Wes Haggard <[email protected]> --------- Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Adds ToolArea and ToolName to single mode telemetry. (#952) * Make registry error message more descriptive. * Set ToolArea and ToolName in single proxy mode. * Update CHANGELOG. * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Update CHANGELOG --------- Co-authored-by: Copilot <[email protected]> * Updated CHANGELOGs for 0.9.9 release --------- Co-authored-by: Fan Yang <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Copilot <[email protected]> * Increment version after release (#957) Increment package version after release * update README (#977) * Prepare `1.0.0` release (#984) * Add instructions on when to not use azd init (#942) * Add instrunctions on when to not use azd init * Update CHANGELOG * Address review feedback * Refactored ToolDescriptionEvaluator code and added more options (#899) * Renamed --validate to --test-single-tool * Refactored Program.cs to remove duplicated tool loading logic * Updated error message logic * Refactored error handling and updated exceptions thrown * Added new --server and --server-exe args and enhanced error handling for missing files and invalid arguments * Updated docs * Fixed syntax errors * Removed azmcp_ prefix from e2eTestPrompts.md * Fixed more issues * Ran TDE * Fixed parameter validation * Updated more usre-facing messages * Updated docs and --help command info * Small doc update * Removed file added by accident. * Renamed header in README * Applied some PR feedback * Applied more PR feedback * Updated logs * Fixed formatting * Merge release branch after `0.9.8` release (#948) * Updated CHANGELOGs for 0.9.8 release * Increment version after release (#946) * Increment package version after release * Add release branch to pull request pipeline --------- Co-authored-by: Wes Haggard <[email protected]> --------- Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Adds ToolArea and ToolName to single mode telemetry. (#952) * Make registry error message more descriptive. * Set ToolArea and ToolName in single proxy mode. * Update CHANGELOG. * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Update CHANGELOG --------- Co-authored-by: Copilot <[email protected]> * Adding CELA approved warnings in README (#955) * Adding CELA approved warnings * Update servers/Azure.Mcp.Server/README.md Co-authored-by: Copilot <[email protected]> * removing localization in docs link --------- Co-authored-by: Copilot <[email protected]> * Updating ToC of Azure MCP readme (#968) * Adding CELA approved warnings * Update servers/Azure.Mcp.Server/README.md Co-authored-by: Copilot <[email protected]> * removing localization in docs link * Updating ToC on Readme --------- Co-authored-by: Copilot <[email protected]> * Fix broken links in README (#979) * Add installation GIF for Azure MCP Server extension in README (2nd attempt) (#978) * Add installation GIF for Azure MCP Server extension in README * Update servers/Azure.Mcp.Server/README.md Co-authored-by: Copilot <[email protected]> * Fix typo in remove-section markers in Azure.Mcp.Server README --------- Co-authored-by: Copilot <[email protected]> * Re-enable smoke tests (#981) Enable smoke tests * Prepare `1.0.0` release * Fix README image reference and rename the gif (#983) Add the install_azure_mcp_server_extension.gif asset and update README to reference the new filename (use underscores instead of dashes). --------- Co-authored-by: Fan Yang <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Sandeep Sen <[email protected]> Co-authored-by: Vinay Gera <[email protected]> Co-authored-by: Chris Harris <[email protected]> * Fix NPM and NuGet smoke tests and updated VS Code plugin to NOT be a preview (#986) * Fix NPM smoke test * Fixed where NPM packages are looked up * Changed the VS Code extension to not be marked as a preview * Increment version after release (#988) Increment package version after release --------- Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Fan Yang <[email protected]> Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Vinay Gera <[email protected]> Co-authored-by: Sandeep Sen <[email protected]> Co-authored-by: Chris Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes a condition that made pipelines skip smoke tests.
GitHub issue number?
N/A
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline