Add AKS tool for listing nodepools #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an AKS nodepool list tool that allows users to list all node pools for a specific Azure Kubernetes Service (AKS) cluster. The tool returns key node pool details including sizing, count, OS type, mode, and autoscaling settings.
Key changes:
- Added
NodepoolListCommandfor listing node pools in an AKS cluster - Extended
IAksServiceandAksServicewithListNodePoolsmethod - Added comprehensive unit and live tests for the new functionality
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tools/Azure.Mcp.Tools.Aks/src/Commands/Nodepool/NodepoolListCommand.cs |
Implements the main command for listing AKS node pools |
tools/Azure.Mcp.Tools.Aks/src/Services/AksService.cs |
Adds ListNodePools method with caching and error handling |
tools/Azure.Mcp.Tools.Aks/src/Services/IAksService.cs |
Extends interface with ListNodePools method |
tools/Azure.Mcp.Tools.Aks/src/Models/NodePool.cs |
Defines NodePool model with comprehensive properties |
tools/Azure.Mcp.Tools.Aks/src/Options/Nodepool/NodepoolListOptions.cs |
Options class for nodepool list command parameters |
tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.UnitTests/Nodepool/NodepoolListCommandTests.cs |
Unit tests for the nodepool list command |
tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.LiveTests/NodepoolCommandTests.cs |
Live integration tests for nodepool functionality |
tools/Azure.Mcp.Tools.Aks/src/Commands/AksJsonContext.cs |
Adds JSON serialization context for NodePool types |
tools/Azure.Mcp.Tools.Aks/src/AksSetup.cs |
Registers the new nodepool command group and list command |
servers/Azure.Mcp.Server/README.md |
Updates documentation with nodepool list example |
servers/Azure.Mcp.Server/CHANGELOG.md |
Documents the new feature addition |
docs/e2eTestPrompts.md |
Adds test prompts for the nodepool list functionality |
docs/azmcp-commands.md |
Updates command documentation with nodepool list usage |
...Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.UnitTests/Nodepool/NodepoolListCommandTests.cs
Outdated
Show resolved
Hide resolved
e457343 to
233458f
Compare
joshfree
approved these changes
Sep 8, 2025
Member
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
joshfree
approved these changes
Sep 8, 2025
jongio
approved these changes
Sep 8, 2025
68ccf2b to
84f2fa7
Compare
Contributor
Author
joshfree
approved these changes
Sep 10, 2025
Member
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
84f2fa7 to
7dd6278
Compare
Contributor
Author
|
/azp run mcp - pullrequest - live |
|
Commenter does not have sufficient privileges for PR 360 in repo microsoft/mcp |
joshfree
approved these changes
Sep 10, 2025
Member
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gossion
approved these changes
Sep 10, 2025
25ba917 to
43de144
Compare
43de144 to
e016dcd
Compare
joshfree
approved these changes
Sep 11, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simlilar existing aks cluster tools, this PR adds nodepool list tool for AKS managed cluster (a nodepool get tool would be added later in a following PR).
GitHub issue number?
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline