-
-
Couldn't load subscription status.
- Fork 7
Description
we have quite a few places where we pass dt's in, and we need to assert their validity
comments:
-
in many places we seem to call Design$new(ps, dt) for that purpose. while this is not so great code, anyway, it also doesnt really do what i thought it does. it does some rudimentary assert but really doesnt check whether the rows are really feasible wrt to the PS
(we should "grep" for Design$new in mlr3tuning and paradox, maybe HB and mbo at least) -
we also need to check whether NAs occur only in the correct places (for subordinate params which are inactive). we had a bad bug, where lots of NAs occured, and then we simply filtered them out through "transpose" and the resulting vector looked valid again. such an assert would have guarded against this bug