-
Notifications
You must be signed in to change notification settings - Fork 2
Add new utilities #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Если ничего не устанавливал, то это не надо коммитить
| ), | ||
| ), | ||
| 'Txuo': text-underline-offset, | ||
| 'Txw':( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это сокращенное свойство, поэтому keywords у него надо указывать вот таким образом
| 'Txwm':( | ||
| 'properties': text-wrap-mode, | ||
| 'keywords': ( | ||
| '': wrap, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Как раз дефолтное значение надо nowrap делать, поскольку wrap - initial значение
| 'keywords': ( | ||
| '': wrap, | ||
| 'w': wrap, | ||
| 'nw': nowrap, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
У него нет других значений на n, поэтому тут n и должно быть
| 'Txws':( | ||
| 'properties': text-wrap-style, | ||
| 'keywords': ( | ||
| '': auto, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto в keywords только в особых случаях указывать надо, поскольку оно и так доступно во всех утилитах. Тут оно вообще initial
| 't': text, | ||
| ), | ||
| 'blend-mode':( | ||
| 'nm': normal, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n, потому что none здесь не планируется
| 'l': lighten, | ||
| 'cd': color-dodge, | ||
| 'cb': color-burn, | ||
| 'hl': hard-light, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 'hl': hard-light, | |
| 'hrl': hard-light, |
| 'pb': padding-box, | ||
| 't': text, | ||
| ), | ||
| 'blend-mode':( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Сюда же можно еще 2 ключевых слова, которые только для mix-blend-mode работают, чтобы сущностей не плодить
| 'multi-list-separator': ml.$tULs1, | ||
| 'keywords': 'transition-props' | ||
| ), | ||
| 'Tsb': ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не хватает опции для разделителя
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А зачем здесь опция для разделителя? Для transition-behavior нет же такой возможности - там это поведение применяется для всех свойств сразу.
| 'properties':'transition-behavior', | ||
| 'keywords':( | ||
| 'nm': normal, | ||
| 'ad': allow-discrete, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вот на это как раз можно дефолтное значение сделать. Если эту утилиту будут юзать, то для него, в первую очередь
| 'Tsb': ( | ||
| 'properties':'transition-behavior', | ||
| 'keywords':( | ||
| 'nm': normal, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 'nm': normal, | |
| 'n': normal, |
No description provided.