Removed a failing iso-format parsing test #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the things that is broken on Android is "including a trailing UTC in the input should work", which is a test added a long time ago, that used the fact that ISO format matched beginning of string. So right now this test goes through Date, which is different on regular vs mobile browser. Also adding UTC at the end doesn't make it parse a UTC date, so its misleading to say the least. I think removing the test makes the most sense in this case. The behavior (of adding UTC at the end is not documented, so shouldn't break legitimate code).
icambron
added a commit
that referenced
this pull request
Oct 14, 2013
Removed a failing iso-format parsing test
|
@ichernev Agree on all points. If you want to tack random stuff on the end of a date string, it had better be handled by the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the things that is broken on Android is "including a trailing UTC in the
input should work", which is a test added a long time ago, that used the fact
that ISO format matched beginning of string.
So right now this test goes through Date, which is different on regular vs
mobile browser. Also adding UTC at the end doesn't make it parse a UTC date, so
its misleading to say the least.
I think removing the test makes the most sense in this case. The behavior (of
adding UTC at the end is not documented, so shouldn't break legitimate code).