Welsh language support #1215
Merged
Welsh language support #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks. One thing: I suspect this should just register itself as |
|
Good point. Up till now I've always worked with locale's rather than language. Bizarrely I'd rather imagined cy as cyrillic, i.e. Russian, but I think I just made that up! |
|
Yeah, Russian is ru (Cyrillic is the script, not the language; according to Google, Russian is русский in Russian, which in Latin characters would be Russkiy). In general, this is useful for language codes: http://en.wikipedia.org/wiki/List_of_ISO_639-1_codes Anyway, thanks for the new language! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please can you add the Welsh translations?