Fix #12461.

KirillOsenkov · marek-safar · commit 725ba2a2523d · 2019-01-17T16:14:09.000+01:00
After .NET 4.5 .NET Framework has changed the System.ComponentModel.Composition ReflectionModelServices.IsExportFactoryImportDefinition to not throw.

Updating this to match the .NET Framework behavior.
diff --git a/mcs/class/System.ComponentModel.Composition.4.5/src/ComponentModel/System/ComponentModel/Composition/ReflectionModel/ReflectionModelServices.cs b/mcs/class/System.ComponentModel.Composition.4.5/src/ComponentModel/System/ComponentModel/Composition/ReflectionModel/ReflectionModelServices.cs
@@ -110,14 +110,6 @@ public static bool IsExportFactoryImportDefinition(ImportDefinition importDefini
         {
             Requires.NotNull(importDefinition, "importDefinition");
 
-            ReflectionImportDefinition reflectionImportDefinition = importDefinition as ReflectionImportDefinition;
-            if (reflectionImportDefinition == null)
-            {
-                throw new ArgumentException(
-                    string.Format(CultureInfo.CurrentCulture, Strings.ReflectionModel_InvalidImportDefinition, importDefinition.GetType()),
-                    "importDefinition");
-            }
-
             return (importDefinition is IPartCreatorImportDefinition);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -110,14 +110,6 @@ public static bool IsExportFactoryImportDefinition(ImportDefinition importDefini`
`110`	`110`	`{`
`111`	`111`	`Requires.NotNull(importDefinition, "importDefinition");`
`112`	`112`
`113`		`- ReflectionImportDefinition reflectionImportDefinition = importDefinition as ReflectionImportDefinition;`
`114`		`- if (reflectionImportDefinition == null)`
`115`		`- {`
`116`		`- throw new ArgumentException(`
`117`		`- string.Format(CultureInfo.CurrentCulture, Strings.ReflectionModel_InvalidImportDefinition, importDefinition.GetType()),`
`118`		`- "importDefinition");`
`119`		`- }`
`120`		`-`
`121`	`113`	`return (importDefinition is IPartCreatorImportDefinition);`
`122`	`114`	`}`
`123`	`115`