Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add the module filename to any stack frames in the crash report #11918

@marek-safar

Description

@marek-safar

We need to add the module filename to any stack frames in the crash report. Currently, we only place the MVID (module version id) as the identifier in crash reports, which means if we cannot resolve the MVID then we have no information about the frame at all (see SymbolizedReport.json…the second frame is not resolved). Here’s the raw form from the un-symbolized report:

        {
          "is_managed" : "true",
          "guid" : "81BA78C8-DC79-4B7F-9F7B-530C53DB0F84",
          "token" : "0x6001763",
          "native_offset" : "0x482",
          "il_offset" : "0x00093"
        },

We must have the module name here to ensure the crash report is trendable between versions. For example, let’s say that the attached issue is caused by Foo.dll. This module will have a different MVID if it has been updated between versions. This means that when we ship two versions of Visual Studio for Mac with the same issue in it, we will create two different failure buckets…causing us to not count hits of this issue correctly (and potentially miss a high impact issue because it was spread to multiple failures).

/cc @leculver

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions