Two System.Data (and verify) tests fail when BCL is compiled with mcs (throw expression followed by ret) #9505
Description
Seems to be invalid IL being generated. My suspicion is that mcs might be generating invalid IL, rather than a PPC JIT issue. Unfortunately, I can't validate on my amd64 system because the test suite consumes all memory until killed. (WTF) Could someone verify with an x86/ARM system with the BCL compiled with mcs and run the System.Data test suite?
This is reproducible on Linux/ppc64le and AIX/ppc64be. (Retitle if it's an mcs issue reproducible elsewhere.)
Tests run: 2405, Passed: 2052, Errors: 2, Failures: 0, Inconclusive: 0
Not run: 351, Invalid: 0, Ignored: 351, Skipped: 0
Elapsed time: 00:00:08.3300000
Errors and Failures:
1) BeginTransaction_Connection_Closed (MonoTests.System.Data.Odbc.OdbcConnectionTest.BeginTransaction_Connection_Closed)
System.InvalidProgramException : Invalid IL code in System.Data.ProviderBase.DbConnectionClosed:BeginTransaction (System.Data.IsolationLevel): IL_0006: ret
at System.Data.Odbc.OdbcConnection.BeginTransaction (System.Data.IsolationLevel isolevel) [0x00000] in /home/builder/jenkins/workspace/test-mono-mainline-community-chroot@3/label/debian-9-ppc64el/external/corefx/src/System.Data.Odbc/src/System/Data/Odbc/OdbcConnection.cs:288
at System.Data.Odbc.OdbcConnection.BeginTransaction () [0x00000] in /home/builder/jenkins/workspace/test-mono-mainline-community-chroot@3/label/debian-9-ppc64el/external/corefx/src/System.Data.Odbc/src/System/Data/Odbc/OdbcConnection.cs:283
at (wrapper remoting-invoke-with-check) System.Data.Odbc.OdbcConnection.BeginTransaction()
at MonoTests.System.Data.Odbc.OdbcConnectionTest.BeginTransaction_Connection_Closed () [0x00006] in /home/builder/jenkins/workspace/test-mono-mainline-community-chroot@3/label/debian-9-ppc64el/mcs/class/System.Data/Test/System.Data.Odbc/OdbcConnectionTest.cs:89
at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00044] in /home/builder/jenkins/workspace/test-mono-mainline-community-chroot@3/label/debian-9-ppc64el/mcs/class/corlib/System.Reflection/MonoMethod.cs:305
2) ServerVersion_Connection_Closed (MonoTests.System.Data.Odbc.OdbcConnectionTest.ServerVersion_Connection_Closed)
System.InvalidProgramException : Invalid IL code in System.Data.ProviderBase.DbConnectionClosed:get_ServerVersion (): IL_0006: ret
at System.Data.Odbc.OdbcConnection.get_ServerVersion () [0x00000] in /home/builder/jenkins/workspace/test-mono-mainline-community-chroot@3/label/debian-9-ppc64el/external/corefx/src/System.Data.Odbc/src/System/Data/Odbc/OdbcConnection.cs:130
at MonoTests.System.Data.Odbc.OdbcConnectionTest.ServerVersion_Connection_Closed () [0x00006] in /home/builder/jenkins/workspace/test-mono-mainline-community-chroot@3/label/debian-9-ppc64el/mcs/class/System.Data/Test/System.Data.Odbc/OdbcConnectionTest.cs:215
at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00044] in /home/builder/jenkins/workspace/test-mono-mainline-community-chroot@3/label/debian-9-ppc64el/mcs/class/corlib/System.Reflection/MonoMethod.cs:305