🐛 replace scalar type __init__ with __new__
#692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9f1255 to
a089fe9
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces __init__ methods with __new__ methods for NumPy scalar types to address MyPy compatibility issues (see referenced GitHub issue). The change aligns the type stubs with Python's scalar type instantiation patterns where __new__ is responsible for instance creation.
- Replaces
__init__with__new__across all scalar type classes - Updates method signatures to return
Selfor specific type instances instead ofNone - Adds test cases for abstract base classes to ensure they cannot be instantiated
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/numpy-stubs/init.pyi | Replaces __init__ with __new__ for all scalar types, updates signatures and parameter names |
| src/numpy-stubs/@test/static/reject/scalars.pyi | Adds test cases for abstract base classes that should reject instantiation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jorenham
added a commit
to jorenham/numpy
that referenced
this pull request
Aug 26, 2025
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
Sep 10, 2025
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/mypy#19732 (comment) for context