-
Notifications
You must be signed in to change notification settings - Fork 51
fix: remove null cwd when executing a command #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
97e8278 to
80d4d99
Compare
b3f99c5 to
e6712e4
Compare
|
|
@utarwyn have a look at https://github.com/phillipCouto/nx-go/commits/issue-151-shell-invalid-cwd/?since=2025-08-24&until=2025-08-24
If you move ahead with my changes this will be a new major release as existing targets assuming the old cwd behaviour will need to be updated. |
@utarwyn did you have a chance to look into my patch? |
This pull request includes a small change to the
executeCommandfunction in thepackages/nx-go/src/utils/execute-command.tsfile. The change removes the default value ofnullfor thecwdparameter, making it an optional parameter without a default value.Closes #151