feat: add name attribute support to Scheduler Configuration #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add name field to Configuration, CreateConfigurationRequest, and UpdateConfigurationRequest models - Add builder support for name attribute in both create and update request classes - Add comprehensive tests for name attribute serialization and builder functionality - Name field is optional and defaults to organizer's name when not set - Fully backward compatible implementation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=========================================
Coverage 80.57% 80.57%
Complexity 333 333
=========================================
Files 36 36
Lines 1014 1014
Branches 88 88
=========================================
Hits 817 817
Misses 138 138
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for an optional "name" field in Scheduler Configuration models to allow custom naming of Scheduling Pages while remaining backward compatible. Key changes include:
- Adding the "name" field to Configuration, CreateConfigurationRequest, and UpdateConfigurationRequest models.
- Incorporating builder methods for the new name attribute in both create and update request classes.
- Adding comprehensive tests to verify serialization and builder functionality for the name attribute.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/kotlin/com/nylas/resources/ConfigurationsTest.kt | Adds tests to verify serialization and request parameter contents including the new name field. |
| src/main/kotlin/com/nylas/models/UpdateConfigurationRequest.kt | Updates the update request model to include the optional name attribute and builder support. |
| src/main/kotlin/com/nylas/models/Scheduler.kt | Updates the main Configuration model to include the optional name attribute. |
| src/main/kotlin/com/nylas/models/CreateConfigurationRequest.kt | Updates the create request model to include the optional name attribute and corresponding builder. |
| CHANGELOG.md | Documents the addition of name attribute support in the Scheduling Configuration. |
pooja169usp
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.